Monthly Attendance Sheet - Group By - getting html tag

umarless · March 18, 2024, 9:31am

Hello Everyone,

In Monthly Attendance Sheet When I select Group By - Departments then in Department Column gets html tag as below.

image432×539 21.6 KB

Please suggest how to rectify it.

Can we use this in formatter in .js file?
frappe.bold(value)

github.com

frappe/hrms/blob/develop/hrms/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py#L71

message += f""" {status} - {abbr} """ count += 1 return message def get_columns(filters: Filters) -> List[Dict]: columns = [] if filters.group_by: columns.append( { "label": _(filters.group_by), "fieldname": frappe.scrub(filters.group_by), "fieldtype": "Link", "options": "Branch", "width": 120,

umarless · March 18, 2024, 9:56am

I made some changes in below files and its working fine.

monthly_attendance_sheet.py

if records:
				data.append({group_by_column: value})
				data.extend(records)

monthly_attendance_sheet.js

if (!summarized_view) {
			if (group_by && column.colIndex == 1) {
				value = "<b>" + value + "</b>";
			}

OUTPUT:

Is that correct way ?

NCP · March 18, 2024, 10:22am

Hi @umarless,

right.

But check the reference, if you want to add some color or something.

github.com

frappe/erpnext/blob/develop/erpnext/selling/report/sales_order_analysis/sales_order_analysis.js#L78-L90


      
          	formatter: function (value, row, column, data, default_formatter) {
          		value = default_formatter(value, row, column, data);
          		let format_fields = ["delivered_qty", "billed_amount"];
          
          		if (in_list(format_fields, column.fieldname) && data && data[column.fieldname] > 0) {
          			value = "<span style='color:green;'>" + value + "</span>";
          		}
          
          		if (column.fieldname == "delay" && data && data[column.fieldname] > 0) {
          			value = "<span style='color:red;'>" + value + "</span>";
          		}
          		return value;
          	},

I hope this helps.

Thank You!

NCP · March 19, 2024, 11:48am

Hi @umarless,

Thank you for letting us know about this problem.

We’ve submitted a Pull Request for versions 15 and 14, so please take a look.

You can find it here:

github.com/frappe/hrms

fix: bold in group by and options mapping

frappe:develop ← Nihantra-Patel:fix_report_format_MAS

opened 11:42AM - 19 Mar 24 UTC

Nihantra-Patel

+13 -2

Version 15 and 14 fixes: #1554 **Before:** - When you use the 'group by' …function, the `` tag shows up and looks messy. Additionally, all links lead directly to the branch doctype. https://github.com/frappe/hrms/assets/141945075/6bf6caf6-c088-494e-b7c6-a6f777cc8676 **After:** - To fix this, we removed the frappe.bold from py and added a condition in the formatter in js. We also corrected the options_mapping. https://github.com/frappe/hrms/assets/141945075/5e893564-74d4-4da5-a341-af4d21a4b5a8 Thank You!

Additionally, we’ve corrected the options_mapping.

Once the Pull Request is merged, the issue will be permanently resolved.

Thank You!

Monthly Attendance Sheet - Group By - getting html tag <strong>