My remotes are 'upstream', not 'origin'

vrms · August 6, 2017, 10:57am

I have an ERPNext instance installed with the easy install script and have noted that the remotes in ~/apps/erpnext aswell as ~/apps/frappe are upstream and not origin (as I would have expected.

I guess practically that makes no difference, so I could do a git remote rename upstream origin to adjust that, right? Or is the upstream on purpose and serves any greater good?

revant_one · August 6, 2017, 12:23pm

upstream is part of frappe/bench and it is required.

Any app installed with command bench get-app, will have remote upstream

github.com

frappe/bench/blob/master/bench/app.py#L220


      
          				sys.exit(1)
          
          
	exec_cmd("{0} uninstall -y {1}".format(pip, app), cwd=bench_path)
          	remove_from_appstxt(app, bench_path)
          	shutil.rmtree(app_path)
          	run_frappe_cmd("build", bench_path=bench_path)
          	if get_config(bench_path).get('restart_supervisor_on_update'):
          		restart_supervisor_processes(bench_path=bench_path)
          	if get_config(bench_path).get('restart_systemd_on_update'):
          		restart_systemd_processes(bench_path=bench_path)
          
          
def pull_all_apps(bench_path='.', reset=False):
          	'''Check all apps if there no local changes, pull'''
          	rebase = '--rebase' if get_config(bench_path).get('rebase_on_pull') else ''
          
          
	# chech for local changes
          	if not reset:
          		for app in get_apps(bench_path=bench_path):
          			excluded_apps = get_excluded_apps()
          			if app in excluded_apps:
          				print("Skipping reset for app {}".format(app))

vrms · August 6, 2017, 12:26pm

ok, thanks for clarifying