Nginx https redirect issue

iHello · April 23, 2016, 1:04am

For example,
old url is http: //domain/my-url
new url is https://domain/my-url;

but when i view http: //domain/my-url , it will redirect to https://domain/? . the right result should be https: //domain/my-url

How to fix it? thanks.

rmehta · April 23, 2016, 5:43am

If I get this clearly, you want to redirect all http traffic to https in nginx?

anand · April 23, 2016, 7:08am

@iHello

Did you setup the https redirect manually? bench setup nginx sets this up correctly if you’ve set ssl_certificate and ssl_certificate_key in site_config.json

anand · April 23, 2016, 7:08am

@iHello

Did you setup the https redirect manually? bench setup nginx sets this up correctly if you’ve set ssl_certificate and ssl_certificate_key in site_config.json

iHello · April 23, 2016, 8:24am

I use bench to setup nginx.
already set ssl_certificate and ssl_certificate_key in site_config.json ;
the issue is it can redirect http->https; but it cann’t redirect to the right url.

iHello · April 23, 2016, 8:25am

Yes. i use bench to setup nginx. and i want all http traffic to https

iHello · April 23, 2016, 8:53am

I fixed this issue now.

github.com

frappe/bench/blob/master/bench/config/templates/nginx.conf

{%- macro nginx_map(from_variable, to_variable, values, default) %}
map {{ from_variable }} {{ to_variable }} {
	{% for (from, to) in values.items() -%}
		{{ from }} {{ to }};
	{% endfor %}

	{%- if default -%}
		default {{ default }};
	{% endif %}
}
{%- endmacro %}

{%- macro server_block(bench_name, port, server_names, site_name, sites_path, ssl_certificate, ssl_certificate_key) %}
server {
	{% if ssl_certificate and ssl_certificate_key %}
	listen {{ port }} ssl;
	{% else %}
	listen {{ port }};
	{% endif %}

This file has been truncated. show original

edit line70
replace:

          return 301 https://$host$request_uri?$query_string;

with

rewrite ^ https://$server_name$request_uri? permanent;

if you have access to the erpnext project’s code. you can contrib it.

saru2020 · February 23, 2022, 8:26pm

i’m facing the same issue where the http traffic is not getting redirected to https.

i tried this solution and still facing the issue.

is there anything else to do on top of this?

note: i did manually install the certs via certbot certonly --standalone and then link the certs by following this frappe documentation

@anand @iHello