Notification Centar V13 - Open documents works?

federico_calvo · August 9, 2021, 1:28pm

Hello everyone, I have an existential question about the new Notification Center in V13.

I can’t get anyone to answer anything referred to in the related issues, nor have I seen a screenshot that can give me an indication that it is working.

The question is that I don’t know how to show the documents that one follows up, which was for me one of the great novelties when it was launched: Anuncio Notification Center where unlike v11, one chose which documents one saw if.

V12:

V13:

I tried dozens of configurations and in different instances as I didn’t see anyone claiming this, so I’m not sure if I misunderstood something.

I didn’t find anything in the documentation either.

Thanks in advance.

federico_calvo · August 13, 2021, 1:46pm

I find it hard to believe that no one uses notifications.

It hurts me to see how beginner posts with “Help plis or Urgent” in the title or without any previous research sometimes get up to 10 replies, and from people I consider important.

Francisco_Buendia · August 13, 2021, 5:18pm

I do, we used to use notifications on v12, was really helpful to have that ordered. Still can’t understand why somethings that worked so well, someone decided to change for no good.

My knowledge coding is less than minimum, sometimes took me weeks or months to find a solution or definitevily have to let it pass, because it seems that the issue I’m having no one else is having or isn’t important.

Sorry Federico, I also haven’t found a solution to this. Good luck, hope you find it and share.

peterg · August 15, 2021, 2:26am

Most of the code related to document subscriptions (“Open Documents”) has been removed from v13, as seen here:

github.com

frappe/frappe/blob/f36513d186ff90707a84e9d6acd576ef8ded9728/frappe/desk/doctype/notification_subscribed_document/notification_subscribed_document.py#L9


      
          # -*- coding: utf-8 -*-
          # Copyright (c) 2019, Frappe Technologies and contributors
          # For license information, please see license.txt
          
          
# import frappe
          from frappe.model.document import Document
          
          
class NotificationSubscribedDocument(Document):
          	pass

On quick search at least, the relevant setting subscribed_documents doesn’t appear to be used for anything. The setting itself, however, seems to have been forgotten and left in.

I suspect that the intention is for people to use workspaces and link cards instead. This makes sense in some regards, but the notifications dropdown could certainly use some love and attention. The notification system is extensible by design, and a developer should be able to add document-specific notifications in with relatively little work by extending the Notifications javascript class:

github.com

frappe/frappe/blob/b0af8886d54ed940111d4eeddca44564db237f56/frappe/public/js/frappe/ui/notifications/notifications.js#L3


      
          frappe.provide('frappe.search');
          
          
frappe.ui.Notifications = class Notifications {
          	constructor() {
          		this.tabs = {};
          		this.notification_settings = frappe.boot.notification_settings;
          		this.make();
          	}
          
          
	make() {
          		this.dropdown = $('.navbar').find('.dropdown-notifications').removeClass('hidden');
          		this.dropdown_list = this.dropdown.find('.notifications-list');
          		this.header_items = this.dropdown_list.find('.header-items');

federico_calvo · August 17, 2021, 5:10pm

Hi @peterg, excellent response. That’s what I suspected, but I didn’t see anyone talking about it.

Maybe make an issue on github to remove the configuration.

I hope this will be useful to others as well.

Thanks!

aakvatech · August 30, 2021, 7:30am

Open Documents that automatically picks up the pending draft in v12 was a very good user experience. I do not see why removing and manually adding link card is a better option.

This should be brought back, or discussed for alternate.

mvarchdev · November 19, 2024, 2:35pm

Hello! I spent whole 2 nights, no sleep at all, lookin why this “Open Documents” feature does not work and what exactly it is used for… I was thinking that you need to set there documents that you allow to get notifications from, because otherwise even when Notifications are set and you are the recipient, you will not see it…

Now, seeing this, made me sad - It would be really great feature to have… Can we just make it getting back? I was looking for code part that did this, but did not find it.