Hi,
In Frappe V 15 HRMS we found that there some calculation errors in working days and payment days in HRMS.
We have 3 scenarios in calculating working days 1) Do Not Include
If we use 1st option then if the person works all the days including holidays then the person should get additional payment. However in V15 it is not calculating for additional working days. Which was calculating in earlier versions eg V14.
@bandarivijay
NCP
May 24, 2024, 5:28am
3
Hi @hpotabatti ,
An issue has already been raised in HRMS. Please check the scenario.
opened 08:36AM - 14 May 24 UTC
bug
### Information about bug
Hi,
In Frappe V 15 HRMS we found that there some c… alculation errors in working days and payment days in HRMS.
We have 3 scenarios in calculating working days 1) Do Not Include
holidays in Total no. of Working Days 2)
Include holidays in Total no. of Working Days and 3)Consider Marked Attendance on Holidays
If we use 1st option then if the person works all the days including holidays then the person should get additional payment. However in V15 it is not calculating for additional working days. Which was calculating in earlier versions eg V14.
### Module
Payroll
### Version
ERPNext: v15.20.6 (version-15)
Frappe HR: v15.19.0 (version-15)
### Installation method
manual install
### Relevant log output / Stack trace / Full Error Message.
_No response_
### Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Hi @NCP and @hpotabatti
I found solution for above issue please refer to below link.
frappe:develop ← KhaledBinAmir:develop
opened 12:14PM - 04 May 24 UTC
The previous logic allowed marking attendance as absent on holidays via consider… _marked_attendance_on_holidays, meaning that if an employee was absent on a holiday, it would be counted as an absence.
**New Logic:**
This PR introduces the following two new variables to extend the behavior:
`consider_marked_absent_attendance_on_holidays`: This retains the original functionality where an absence on holidays will be marked as absent, provided that Include holidays in Total no. of Working Days is enabled.
`consider_marked_present_attendance_on_holidays`: This new variable introduces the option to count attendance as present on holidays if Include holidays in Total no. of Working Days is not enabled. Previously, present attendance on holidays was ignored.
These changes allow combining the checkboxes "Include holidays in Total no. of Working Days" and "Consider Marked Attendance on Holidays," so that attendance logic accurately reflects the combined settings. also removed display on dependency in `payroll_settings.json`.