Pdf on submit public file

Santhosh_Kumar · September 1, 2021, 7:49pm

How to change the pdf on submit files to public by default during creation itself.

Now it is creating as private file

kennethsequeira · September 2, 2021, 6:21pm

Looks like it’s hardcoded to save the file as private:

alyf-de/erpnext_pdf-on-submit/blob/b91757731d2c795072119d44aad37496c6945068/pdf_on_submit/attach_pdf.py#L114


      
          
          

          
def save_and_attach(content, to_doctype, to_name, folder):
              """
              Save content to disk and create a File document.
          
          
    File document is linked to another document.
              """
              file_name = "{}.pdf".format(to_name.replace(" ", "-").replace("/", "-"))
              save_file(file_name, content, to_doctype,
                        to_name, folder=folder, is_private=1)

Changing is_private = 0 should save it as a public file.

You should let the creator know about this so they can make it a configurable feature.

cc @rmeyer

rmeyer · September 3, 2021, 11:51am

This is would a a dangerous setting. This app is intended to create PDFs of quotations, sales orders, sales invoices etc. I cannot imagine a case where these should be available to the public.