PDF output looks bad

daniel · February 7, 2016, 6:59pm

Hi @all,

I am looking for a solution on how to make the PDF printout look exactly the same as on the preview. Seems that it is not working sind 2014 guess we have discussed this topic already earlier.

Since I am now actively working on my ERPNext v6 copy I am still wondering why the PDF does not look as expected

Any clues what’s wrong?

Btw the Problem:
Tables created in the Format-Builder are not going to be printed correctly, they are stated all below each other.

Only the “Title” and the products-table is shown (nearly) as expected.

Any others got that problem?

Edit:
Seems that this “issue” is working in Odoo…maybe we should take a look at “their” PDF engine?

Cheers,
Dan

daniel · February 7, 2016, 7:48pm

Hi,

since I stumbled upon a few hints on external sources regarding wk html to pdf I am about to build a complete custom form using my HTML and CSS Knowledge. That works so far very well with “static” data.

Since you know I’ve moved from V4 I still have the following code made for my last printout…but it seems to be not valid any more.

{% for doc in data %}

                                                    <td>{{ doc.idx }}</td>

                                                            <td>{{ doc.item_code }}</td>
                                                            <td>{{ doc.item_name }}</td>
                                                            <br>{{ doc.description }}</td>
                                                            <td class="text-right">{{ doc.qty }}</td>
                                                             <td class="text-right">{{ doc.get_formatted("base_price_list_rate") }}{%- if doc.discount_percentage -%}<br>- {{ doc.discount_percentage }} %{%- endif -%}</td>
                                                            <td class="text-right">{{ doc.get_formatted("base_amount") }}</td>


                                            </tr>
                                            {% endfor %}

anand · February 8, 2016, 1:07pm

@daniel can you share screenshots?

also can you reproduce this at https://demo.erpnext.com?

daniel · February 9, 2016, 4:07pm

@anand
Thanks for your message.
I cannot reproduce @ demo because I can’t create a new print-template.

Regarding screenshot:

The first one is - as you assume - the “original printout”.
The second one is my company’s CI lookalike…ps: the table with products is just dummy-data as it is not working

edit:
can we delete the “Draft” as well?

best,
Dan

daniel · February 10, 2016, 9:57am

no one?

anand · February 10, 2016, 10:05am

In the Print Format record, you need to set:

Standard = No
Custom Format = checked
Print Format Type = Standard
Write your code in HTML

Now you can write any Jinja that you want. See the help at the bottom of the Print Format doc.

daniel · February 15, 2016, 4:39pm

daniel:

{% for doc in data %}

                                                &lt;td&gt;{{ doc.idx }}&lt;/td&gt;

                                                        &lt;td&gt;{{ doc.item_code }}&lt;/td&gt;
                                                        &lt;td&gt;{{ doc.item_name }}&lt;/td&gt;
                                                        &lt;br&gt;{{ doc.description }}&lt;/td&gt;
                                                        &lt;td class="text-right"&gt;{{ doc.qty }}&lt;/td&gt;
                                                         &lt;td class="text-right"&gt;{{ doc.get_formatted("base_price_list_rate") }}{%- if doc.discount_percentage -%}&lt;br&gt;- {{ doc.discount_percentage }} %{%- endif -%}&lt;/td&gt;
                                                        &lt;td class="text-right"&gt;{{ doc.get_formatted("base_amount") }}&lt;/td&gt;


                                        &lt;/tr&gt;
                                        {% endfor %}

This is still not working

daniel · February 22, 2016, 2:48pm

@anand,

Sorry for bothering you again. But I tried not a lot…it does not recognize “doc.” do I have to call a macro before?

Best,
Dan

anand · February 22, 2016, 2:51pm

@daniel

There is no variable called ‘data’, use doc only

daniel · February 22, 2016, 3:29pm

@anand

Wow, that was a really fast information. Yep, the output is not “ok”. One more question, how is the page-break defined in standard output? I can’t seen to find it in standard.html…

Edit:
I’d like to help you and share my code with others…but where is the printout of the PDF itself defined?
I want to add a header to the printout and I want to check if advanced WKHTMLTOPDF options are possible. This may help further development of ERPNext? Thanks already in advance @anand

best,
Dan

anand · February 23, 2016, 2:13pm

Give a div class=“page-break”

daniel · February 24, 2016, 8:38am

thank you @anand

But basically what I mean in detail is:
Where is the function itself that generates the PDF. Because since WKHTMLTOPDF offers a variety of options like header and footer for printout, I’d like to test it. But I can’t seem to find the corresponding file to change it.

Thanks in advance!
Daniel

anand · February 24, 2016, 11:54am

Search for pdf.py

daniel · February 24, 2016, 4:57pm

Hi @anand,

thanks for that information.
You guess right: another question arises now…sorry for that

I am now running a multi-site-setup with 3x ERPNext. Problem…when I change e.g. the --background in pdf.py options, that changes my output in all 3 sites…is there a change to differentiate?

Best,
Daniel

anand · February 24, 2016, 5:41pm

Since the code is common, it will affect all sites.

You should either put the modified code in another frappe app and call it via hook, or use multiple benches. But right now multiple benches will be tricky to setup.

daniel · February 26, 2016, 3:05pm

I have to admit that the hooks are not my first choice…a multi-bench-setup would be f* great but right now since this is kind of tricky I won’t recommend that either.

I guess the better choice here is to choose more servers ?

What just came to my mind…how about doing it with like an if function. Is there a possibility for the pdf.py to determine which site is calling the python file?

anand · February 26, 2016, 3:08pm

You are in luck. We are going to release a multi-bench fix next week: [Major] Multi-bench setup by shreyasp · Pull Request #187 · frappe/bench · GitHub

daniel · February 26, 2016, 3:09pm

@anand
Where can I just put you on top of my fav devs this

IS AWESOME.

daniel · March 1, 2016, 1:32pm

so this is due in a few days?
Daniel

anand · March 1, 2016, 5:21pm

Yes still a few issues to iron out before it is ready for production use