Permission in Version 4

Frappe HR
26
‎Hi Rushabh, 

Trust you're doing great. How does creating separate IDs solve the issue? Also, I'm sure you do realize that creating different IDs for separate roles makes using the system quite cumbersome; definitely not the way to go (IMHO) 



Kind regards,
Olawale‎
From: Rushabh Mehta
Sent: Monday, August 25, 2014 6:56 AM
To: er...@googlegroups.com
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission in Version 4

We were going through some use cases and we find that there are more use cases for AND rather than OR.

@Mayurm If you have a user where you want to give specific permissions based on role, I suggest you create separate user ids for that user (Allison Purchase & Allison HR)

https://github.com/frappe/erpnext/wiki/Version-4-Permission-Use-Cases

If you have more use cases, please add to the wiki page.



On 23-Aug-2014, at 6:11 pm, wa...@xavierltd.com wrote:

‎Hi Rushabh, 

I agree about using the OR approach as long as there is additional scripting to handle the scenario I described earlier. If what you're saying is that you want to return the permission manager to functioning how it was in version 3 then that's just great!

The key thing to keep in mind is that you need a way to filter docs within a list for 'roles' probably based on ‎link fields and this needs to override normal user restrictions (which is where the OR comes in I guess) 

By the way, having a hierarchical structure with workflows ‎configured around it would be absolutely awesome ;) 


Kind regards,
Olawale ‎
From: Rushabh Mehta
Sent: Saturday, August 23, 2014 5:04 AM
To: er...@googlegroups.com
Reply To: er...@googlegroups.com
Cc: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission in Version 4

Olawale, permissions were OR in version 3, so it makes sense to keep them that way. Additional restrictions can be done via scripting.

@anand let's discuss this Monday.

@rushabh_mehta
via mobile

On 22-Aug-2014, at 6:46 PM, wa...@xavierltd.com wrote:

‎Hi Rushabh, 

Trust you're doing great. Not so sure that's a good idea. Check out the following scenario:

-An employee is restricted to seeing only his employee form because he has his Employee ID defined in his user properties

-Same employee also has Department defined in his user properties so that the department field is automatically populated and marked when he raises a document (as in Mayur's example)

-If restrictions are set to OR then it means that this employee (and every other employee who has Department defined in their user properties) will be able to view employee forms for everyone in his department! 

Best solution is still ability to ignore user permissions on fields ‎for specific roles (IMO)

Cheers! 


Kind regards,
Olawale ‎
From: Rushabh Mehta
Sent: Friday, August 22, 2014 1:52 PM
Subject: Re: [erpnext-user-forum] Permission in Version 4

Maybe we should make it OR, it might fix a lot of issues.

@rushabh_mehta
via mobile

On 22-Aug-2014, at 5:21 PM, Anand Doshi <an...@iwebnotes.com> wrote:

They are AND

A user will be restricted for Company in (X, Y) and Department in (A, B, C)

-Anand. 

Sent from my phone

On 22-Aug-2014, at 16:53, Mayur Patel <ma...@gmail.com> wrote:

Hi Rushabh,

I think they are AND. But we will wait for Anand to confirm it.

Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/d5bae375-c3a2-4aff-830f-34ec389fb3d0%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/5F69A96C-F75F-4965-8F80-DE60E7E7B1BB%40iwebnotes.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/2D4031E3-3799-4D0A-90DD-D03FF9D07086%40gmail.com.

For more options, visit https://groups.google.com/d/optout.



–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140822131646.5378180.88841.9698%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/E4EBB59A-BCD2-48A4-8EA4-B03D917A170A%40gmail.com.

For more options, visit https://groups.google.com/d/optout.




–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140823124142.5378180.86740.9728%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/A92DC55B-727E-4AC5-868B-446BEF087B79%40gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140825070729.5378180.92866.9749%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

27
Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome.  Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).

Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

28
@Wale and @Mayur,

Have a look at this: https://github.com/frappe/frappe/pull/795

This should solve all your problems. The pull request is pending review and merge.


Thanks,
Anand.



On Tue, Aug 26, 2014 at 6:39 PM, Mayur Patel <ma…@gmail.com> wrote:

Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome. Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1ZfgU7Yff2HC8jtcn%2BhqH-spQJ%3DoeFPPZsORRf%3DsuphA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

29
Hi Anand, 

This looks excellent! If I'm correct, this way we can determine which doc-types are considered for each role. Therefore, un-checking the employee doc-type for example, would allow a user with the appropriate role (e.g HOD) to bypass the restrictions of the 'From Employee' field in an Expense Claim document. Right? 

Thanks a lot for this! Awaiting the review and merge 


Kind regards,
Olawale‎
From: Anand Doshi
Sent: Tuesday, August 26, 2014 3:10 PM
To: ERPNext User's Forum
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission in Version 4

@Wale and @Mayur,

Have a look at this: https://github.com/frappe/frappe/pull/795

This should solve all your problems. The pull request is pending review and merge.

‎
Thanks,
Anand.



On Tue, Aug 26, 2014 at 6:39 PM, Mayur Patel <ma…@gmail.com> wrote:

Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome.  Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1ZfgU7Yff2HC8jtcn%2BhqH-spQJ%3DoeFPPZsORRf%3DsuphA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140826154457.5378180.69660.9829%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

30
Yes. Exactly. 

Sent from my phone

On 26-Aug-2014, at 21:14, wa...@xavierltd.com wrote:

Hi Anand, 

This looks excellent! If I'm correct, this way we can determine which doc-types are considered for each role. Therefore, un-checking the employee doc-type for example, would allow a user with the appropriate role (e.g HOD) to bypass the restrictions of the 'From Employee' field in an Expense Claim document. Right? 

Thanks a lot for this! Awaiting the review and merge 


Kind regards,
Olawale‎
From: Anand Doshi
Sent: Tuesday, August 26, 2014 3:10 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission in Version 4

@Wale and @Mayur,

Have a look at this: https://github.com/frappe/frappe/pull/795

This should solve all your problems. The pull request is pending review and merge.

‎
Thanks,
Anand.



On Tue, Aug 26, 2014 at 6:39 PM, Mayur Patel <ma…@gmail.com> wrote:

Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome.  Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1ZfgU7Yff2HC8jtcn%2BhqH-spQJ%3DoeFPPZsORRf%3DsuphA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140826154457.5378180.69660.9829%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/DEC50A2D-8B92-41A7-A4C9-DC484450375B%40iwebnotes.com.

For more options, visit https://groups.google.com/d/optout.

31
Hi Wale and Mayur,

New feature, selectable DocTypes for applying User Permissions, has been released.

This is now possible:
screen shot 2014-08-29 at 11 39 56 am


Thanks,
Anand.


On Tue, Aug 26, 2014 at 10:05 PM, Anand Doshi <an...@iwebnotes.com> wrote:
Yes. Exactly.

Sent from my phone

On 26-Aug-2014, at 21:14, wa...@xavierltd.com wrote:


Hi Anand,


This looks excellent! If I'm correct, this way we can determine which doc-types are considered for each role. Therefore, un-checking the employee doc-type for example, would allow a user with the appropriate role (e.g HOD) to bypass the restrictions of the 'From Employee' field in an Expense Claim document. Right?


Thanks a lot for this! Awaiting the review and merge



Kind regards,
Olawale‎

From: Anand Doshi
Sent: Tuesday, August 26, 2014 3:10 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission in Version 4

@Wale and @Mayur,

Have a look at this: https://github.com/frappe/frappe/pull/795

This should solve all your problems. The pull request is pending review and merge.

‎
Thanks,
Anand.



On Tue, Aug 26, 2014 at 6:39 PM, Mayur Patel <ma…@gmail.com> wrote:

Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome. Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1ZfgU7Yff2HC8jtcn%2BhqH-spQJ%3DoeFPPZsORRf%3DsuphA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140826154457.5378180.69660.9829%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1AQevfwdKgQSBFVdLAAEGt_EwcV9iKgVs-4V1vT2w9RQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

32
‎Hi Anand, 

Thanks a lot for this update. You guys are simply awesome! 


Kind regards,
Olawale ‎
From: Anand Doshi
Sent: Friday, August 29, 2014 7:26 AM
To: er...@googlegroups.com
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission in Version 4

Hi Wale and Mayur,

New feature, selectable DocTypes for applying User Permissions, has been released.

This is now possible:
screen shot 2014-08-29 at 11 39 56 am


Thanks,
Anand.


On Tue, Aug 26, 2014 at 10:05 PM, Anand Doshi <an...@iwebnotes.com> wrote:
Yes. Exactly. 

Sent from my phone

On 26-Aug-2014, at 21:14, wa...@xavierltd.com wrote:


Hi Anand, 


This looks excellent! If I’m correct, this way we can determine which doc-types are considered for each role. Therefore, un-checking the employee doc-type for example, would allow a user with the appropriate role (e.g HOD) to bypass the restrictions of the ‘From Employee’ field in an Expense Claim document. Right? 


Thanks a lot for this! Awaiting the review and merge 



Kind regards,
Olawale‎

From: Anand Doshi
Sent: Tuesday, August 26, 2014 3:10 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission in Version 4

@Wale and @Mayur,

Have a look at this: https://github.com/frappe/frappe/pull/795

This should solve all your problems. The pull request is pending review and merge.

‎
Thanks,
Anand.



On Tue, Aug 26, 2014 at 6:39 PM, Mayur Patel <ma…@gmail.com> wrote:

Hi Rushabh,

I agree with Olawale. Having multiple user accounts is very cumbersome.  Alison was just an example users. We have more than 1 users for whom this is an issue. We should look at why this was not an issue in Version 3 and why it is an issue in Version 4. In Version 3, only one use permission was being applied, while in Version 4 multiple user permissions are applied (based on link fields).


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/c8e8f0d8-2db0-492e-9c88-bb9fedab687f%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1ZfgU7Yff2HC8jtcn%2BhqH-spQJ%3DoeFPPZsORRf%3DsuphA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140826154457.5378180.69660.9829%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1AQevfwdKgQSBFVdLAAEGt_EwcV9iKgVs-4V1vT2w9RQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140829071502.5402757.91341.9945%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

33
Great Anand.

But I am unable to test it as "bench update" is giving me below error messages. As per your suggestion, I checked "Ignore User Permissions" for Reports To field for Employee doctype and Updated it. This fixed the issue I was having. But because of this employee.json file got updated on the server. So now whenever I run “bench update”, I am getting below error message. How do I resolve it? Thanks.

 

From https://github.com/frappe/erpnext

* branch            HEAD       -> FETCH_HEAD

Updating 79f9110..ec8964d

error: Your local changes to the following files would be overwritten by merge:

        erpnext/hr/doctype/employee/employee.json

Please, commit your changes or stash them before you can merge.

Aborting

Error: None

Traceback (most recent call last):

  File "/usr/local/bin/bench", line 9, in <module>

    load_entry_point('bench==0.1', 'console_scripts', 'bench')()

  File "/var/www/bench-repo/bench/cli.py", line 27, in cli

    return bench()

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 488, in __call__

    return self.main(*args, **kwargs)

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 474, in main

    self.invoke(ctx)

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 758, in invoke

    return self.invoke_subcommand(ctx, cmd, cmd_name, ctx.args[1:])

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 767, in invoke_subcommand

    return cmd.invoke(cmd_ctx)

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 659, in invoke

    ctx.invoke(self.callback, **ctx.params)

  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 325, in invoke

    return callback(*args, **kwargs)

  File "/var/www/bench-repo/bench/cli.py", line 107, in update

    pull_all_apps()

  File "/var/www/bench-repo/bench/app.py", line 49, in pull_all_apps

    exec_cmd("git pull {rebase} upstream HEAD".format(rebase=rebase), cwd=app_dir)

  File "/var/www/bench-repo/bench/utils.py", line 56, in exec_cmd

    subprocess.check_call(cmd, cwd=cwd, shell=True)

  File "/usr/lib/python2.7/subprocess.py", line 511, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command 'git pull  upstream HEAD' returned non-zero exit status 1

34
@Mayur,

You can git checkout the employee.json file. Ideally, for such customizations you can also use Customize Form :)

Check if "git status" shows any unmerged files after that.


If there are no such files, bench update should work.

-Anand.




On Fri, Aug 29, 2014 at 3:56 PM, Mayur Patel <ma…@gmail.com> wrote:

Great Anand.

But I am unable to test it as "bench update" is giving me below error messages. As per your suggestion, I checked "Ignore User Permissions" for Reports To field for Employee doctype and Updated it. This fixed the issue I was having. But because of this employee.json file got updated on the server. So now whenever I run “bench update”, I am getting below error message. How do I resolve it? Thanks.

From https://github.com/frappe/erpnext

* branch HEAD -> FETCH_HEAD

Updating 79f9110..ec8964d

error: Your local changes to the following files would be overwritten by merge:

erpnext/hr/doctype/employee/employee.json

Please, commit your changes or stash them before you can merge.

Aborting

Error: None

Traceback (most recent call last):

File "/usr/local/bin/bench", line 9, in <module>

load_entry_point('bench==0.1', 'console_scripts', 'bench')()

File "/var/www/bench-repo/bench/cli.py", line 27, in cli

return bench()

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 488, in __call__

return self.main(*args, **kwargs)

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 474, in main

self.invoke(ctx)

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 758, in invoke

return self.invoke_subcommand(ctx, cmd, cmd_name, ctx.args[1:])

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 767, in invoke_subcommand

return cmd.invoke(cmd_ctx)

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 659, in invoke

ctx.invoke(self.callback, **ctx.params)

File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 325, in invoke

return callback(*args, **kwargs)

File "/var/www/bench-repo/bench/cli.py", line 107, in update

pull_all_apps()

File "/var/www/bench-repo/bench/app.py", line 49, in pull_all_apps

exec_cmd("git pull {rebase} upstream HEAD".format(rebase=rebase), cwd=app_dir)

File "/var/www/bench-repo/bench/utils.py", line 56, in exec_cmd

subprocess.check_call(cmd, cwd=cwd, shell=True)

File "/usr/lib/python2.7/subprocess.py", line 511, in check_call

raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command 'git pull upstream HEAD' returned non-zero exit status 1


Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/93da4809-780b-4392-a560-4d3940a3d174%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAAQzbF1Uk2s2v_J%3DEsnOa-dvjyQgb7WoQWeyb8juZ8%2BAFkvCSA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

35
Hi Anand,

I used Customize Form for checking "Ignore User Permissions" for Employee Doctype. Didn't that changed the employee.json file?

Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/df9422fd-de41-430c-ad88-c630307f6641%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

36
Hi Anand,

Using Customize Form didn't change the employee.json file on the server but "Role Permissions Manager" seems to updates the  employee.json file on the server every time any changes are made to the permission for Employee doctype. I can confirm that this is true for other doctype too. Doesn't this create an issue every time we run "bench update" command?

Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/b89bd60e-d154-4dad-a626-7e81d169b835%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

37
You must have set developer mode
It updates the json files too. 

Sent from my phone

On 29-Aug-2014, at 17:05, Mayur Patel <ma...@gmail.com> wrote:

Hi Anand,

Using Customize Form didn't change the employee.json file on the server but "Role Permissions Manager" seems to updates the  employee.json file on the server every time any changes are made to the permission for Employee doctype. I can confirm that this is true for other doctype too. Doesn't this create an issue every time we run "bench update" command?

Kind regards,
Mayur Patel

–

You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/b89bd60e-d154-4dad-a626-7e81d169b835%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

–

You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/BCD61F66-2099-4FCE-85D2-2C36A32452AF%40iwebnotes.com.

For more options, visit https://groups.google.com/d/optout.

38

Hi Anand,

I finally got a chance to test the permission module enhancements that your team has made.It is not working as per our previous discussions (see above post). Our requirement and setup is described below again.

  • We have 6 companies in our ERPNext implementation.
  • We have total of 92 users.
  • Every user is allowed to view and modify purchase orders for the companies they are assigned to. We have 30+ users who are assigned to multiple companies (3 companies out of 6 companies for now).
  • In our implementation, we have setup a custom field called ‘Purchase Order Approver’ for ‘Purchase Order’ doctype. It is a linked field to ‘User’ doctype and it is mandatory field.
  • When a user create a purchase order he/she selects the ‘Purchase Order Approver’ from the user list.
  • A Purchase Order can only be approved (submitted) by the user whose name is selected as as ‘Purchase Order Approver’.
  • We have 18 users in our system who are classified as purchase order approver.

Below is what we have setup in ERPNext:

  • We have given ‘Purchase User’ role read,write, create and report permissions with ‘Apply User Permissions’ ticked and we have selected ‘Company’ under ‘Select Document Types’. - This role is assigned to every single users in the system so that they can see all purchase orders for the companies they are assigned to.

  • We have given ‘Purchase Approver’ role read, write, create, submit, cancel and report permission with ‘Apply User Permissions’ ticked and we have selected ‘User’ under ‘Select Document Types’. - This role is assigned to 18 users who are purchase order approver so that they can approve (submit) purchase orders for which they are listed as purchase order approver.

  • Allan is one of the user who is a purchase order approver. Allan is assigned to 3 companies. Allan is assigned to both ‘Purchase User’ and ‘Purchase Approver’ roles.

What happens when Allan logs in:

  • Allan can see all the purchase order for the companies he is assigned to.
  • He can see all pending order for the companies he is assigned to.
  • He clicks on one of the pending orders and finds that ‘Mayur Patel’ is listed as Purchase Order Approver. But system shows Allan Submit buttons on the top and he is able to click on it and able to Submit the order which he shouldn’t.

Above is working fine in version 3.0 and would like to make sure it works in version 4.0 (and all other future version). Without this functionality we can’t migrate to version 4.0 and take advantages of all new features and enhancements of such a wonderful product upgrade.

Let me know if you need any other information or clarifications.Thanks.

Kind regards,
Mayur Patel

39

Hi Mayur

It should’ve worked as there is a test case for this kind of scenario afaik.

Check if Purchase Order Approver is a link field with options as User and “Ignore User Permissions” unchecked.

Thanks
Anand.

40

Hi Anand,

Thanks for your reply. I have checked and can confirm that it is a link field and the check box is unticked.

Mayur

41

Hi Anand,

Any update?

Kind regards,
Mayur

42

Hi Anand (@anand),

Any update on above permission issue? Without this fix, we are not able to go ahead with upgrade from CGI version to the version 4.0 and possible to version 5.0 once it has been released.

Thanks in advance.

Kind regards,
Mayur Patel

43

Hi Anand (@anand),

Can we please have a quick screen sharing session to go through our ERPNext instance to sort this out? This is quite urgent.

Kind regards,
Mayur Patel

44

You might want to do a screenshare with @umair to get a quick resolve.

@umair - please set this up.

45

Will look into this and get back to you.