Permission Manager Issue

‎Hi All, 

Trust everyone's doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I'm hoping someone else has been able to find a way around.

‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I'll give a common scenario below.

Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO. 

In version 3, all we needed to do was:

1. Insert 'Department' field into relevant docs 
2. Create 'Manager' role 
3. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees 
4. In Permission Manager, select 'Department' as condition for ‎Manager role in the relevant docs. 

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee's department was changed, his new manager would automatically have access to his documents.

How is this achieved in version 4?



Kind regards,
Olawale



You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:
‎Hi All,

Trust everyone's doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I'm hoping someone else has been able to find a way around.

‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I'll give a common scenario below.

Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.

In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.

http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa

In version 3, all we needed to do was:

1. Insert 'Department' field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
3. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.

http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew
4. In Permission Manager, select 'Department' as condition for ‎Manager role in the relevant docs.

In the upgrade Permission Manager, if "Apply User Permission" is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.

If you don't particular User Property applied, you should check "Ignore User Permission" for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee's department was changed, his new manager would automatically have access to his documents.

If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.

How is this achieved in version 4?



Kind regards,
Olawale



You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com

Hi Umair, 

Thanks for your reply. The ‎issue is at step 2 in your outline:

‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers... at least not visibly.

The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".

There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want! 

‎I hope you're seeing the issue now. Any suggestions?


Kind regards,
Olawale Olowu
wa...@xavierltd.com
Tel: 08075390014
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:
‎Hi All, 

Trust everyone's doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I'm hoping someone else has been able to find a way around.

‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I'll give a common scenario below.

Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.

In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.

http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa

In version 3, all we needed to do was:

1. Insert 'Department' field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
 
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
 
3. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.

http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew
 
4. In Permission Manager, select 'Department' as condition for ‎Manager role in the relevant docs. 

In the upgrade Permission Manager, if "Apply User Permission" is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.

If you don't particular User Property applied, you should check "Ignore User Permission" for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions
 
With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee's department was changed, his new manager would automatically have access to his documents.

If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.

How is this achieved in version 4?



Kind regards,
Olawale



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:
Hi Umair,

Thanks for your reply. The ‎issue is at step 2 in your outline:

‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers... at least not visibly.

Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.

The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".

There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!

Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?

‎I hope you're seeing the issue now. Any suggestions?


Kind regards,
Olawale Olowu
wa...@xavierltd.com
Tel: 08075390014
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All,


Trust everyone's doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I'm hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I'll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert 'Department' field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

  1. In Permission Manager, select 'Department' as condition for ‎Manager role in the relevant docs.

In the upgrade Permission Manager, if "Apply User Permission" is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don't particular User Property applied, you should check "Ignore User Permission" for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions


With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee's department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale



You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com
Hi Umair,

Yes, the 2 conditions you mentioned have b‎een set accordingly 

No, the user properties for manager does not have employees defined because as per your outline, the final approving authority (ie GM/CEO) is the one set as approving authority. 

I do not welcome the idea of manually adding ‎employees to manager properties because it doesn't seem like a workable/sustainable solution. What it implies is that if a department (e.g Sales) has 100 employees, then we need to individually add 100 employee IDs to the manager's user permission‎s!

What of in a scenario where employees are transferred from one department to another (this happens quite often)? The system will still allow the former manager to see/approve expenses until the employee IDs are manually dele‎ted from one manager's profile and added to the other??

Why can't this just work like version 3 where you could simply set a cond‎ition for the manager to view docs for all employees whose department matches his own? 

This was a much more graceful solution and it had the added advantage that once an employee's department changes, the new manager automatically gets access to his docs and the former manager stops seeing them.


Kind regards,
Olawale ‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 1:29 PM
To: ERPNext User's Forum
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:
Hi Umair, 

Thanks for your reply. The ‎issue is at step 2 in your outline:

‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers... at least not visibly.

Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.

The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".

There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!

Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?

‎I hope you're seeing the issue now. Any suggestions?


Kind regards,
Olawale Olowu
wa...@xavierltd.com
Tel: 08075390014
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All, 


Trust everyone’s doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I’m hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I’ll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert ‘Department’ field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
 
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
 
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

 

  1. In Permission Manager, select ‘Department’ as condition for ‎Manager role in the relevant docs. 

In the upgrade Permission Manager, if “Apply User Permission” is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don’t particular User Property applied, you should check “Ignore User Permission” for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions

 

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee’s department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvKpcHdFLogZb_Z%3DpYbgD1WZZ%3DYJ6_6%3DBjG10OkWiK00g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820125919.5402755.90903.9568%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

Maybe this can be linked directly to the Department / Branch for Leave and Expenses. Maybe create a table where you can set employee and whether that employee is a leave / expense manager and that would define the rules for approval...




On 20-Aug-2014, at 6:29 pm, wa...@xavierltd.com wrote:

Hi Umair,

Yes, the 2 conditions you mentioned have b‎een set accordingly 

No, the user properties for manager does not have employees defined because as per your outline, the final approving authority (ie GM/CEO) is the one set as approving authority. 

I do not welcome the idea of manually adding ‎employees to manager properties because it doesn't seem like a workable/sustainable solution. What it implies is that if a department (e.g Sales) has 100 employees, then we need to individually add 100 employee IDs to the manager's user permission‎s!

What of in a scenario where employees are transferred from one department to another (this happens quite often)? The system will still allow the former manager to see/approve expenses until the employee IDs are manually dele‎ted from one manager's profile and added to the other??

Why can't this just work like version 3 where you could simply set a cond‎ition for the manager to view docs for all employees whose department matches his own? 

This was a much more graceful solution and it had the added advantage that once an employee's department changes, the new manager automatically gets access to his docs and the former manager stops seeing them.


Kind regards,
Olawale ‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 1:29 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:
Hi Umair, 

Thanks for your reply. The ‎issue is at step 2 in your outline:

‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers... at least not visibly.

Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.

The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".

There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!

Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?

‎I hope you're seeing the issue now. Any suggestions?


Kind regards,
Olawale Olowu
wa...@xavierltd.com
Tel: 08075390014
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All, 


Trust everyone’s doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I’m hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I’ll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert ‘Department’ field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
 
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
 
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

 

  1. In Permission Manager, select ‘Department’ as condition for ‎Manager role in the relevant docs. 

In the upgrade Permission Manager, if “Apply User Permission” is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don’t particular User Property applied, you should check “Ignore User Permission” for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions

 

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee’s department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvKpcHdFLogZb_Z%3DpYbgD1WZZ%3DYJ6_6%3DBjG10OkWiK00g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.






You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820125919.5402755.90903.9568%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/F6E05D5D-63E5-46EE-92CE-0B93BDACA95F%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

Or perhaps option of Role-wise "Ignore User Permission" will do it.

If we can Ignore User Permission check on "For Employee" field just for the Managers Role, there will be no need to create User Property for each Approver-Employee.

Currently "Ignore User Permission" option in the Customize form is applied for all the users.


On Wed, Aug 20, 2014 at 6:33 PM, Rushabh Mehta <rm...@gmail.com> wrote:
Maybe this can be linked directly to the Department / Branch for Leave and Expenses. Maybe create a table where you can set employee and whether that employee is a leave / expense manager and that would define the rules for approval...




On 20-Aug-2014, at 6:29 pm, wa...@xavierltd.com wrote:

Hi Umair,

Yes, the 2 conditions you mentioned have b‎een set accordingly

No, the user properties for manager does not have employees defined because as per your outline, the final approving authority (ie GM/CEO) is the one set as approving authority.

I do not welcome the idea of manually adding ‎employees to manager properties because it doesn't seem like a workable/sustainable solution. What it implies is that if a department (e.g Sales) has 100 employees, then we need to individually add 100 employee IDs to the manager's user permission‎s!

What of in a scenario where employees are transferred from one department to another (this happens quite often)? The system will still allow the former manager to see/approve expenses until the employee IDs are manually dele‎ted from one manager's profile and added to the other??

Why can't this just work like version 3 where you could simply set a cond‎ition for the manager to view docs for all employees whose department matches his own?

This was a much more graceful solution and it had the added advantage that once an employee's department changes, the new manager automatically gets access to his docs and the former manager stops seeing them.


Kind regards,
Olawale ‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 1:29 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:

Hi Umair,


Thanks for your reply. The ‎issue is at step 2 in your outline:


‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

                                                                                                                                 <div style="width:100%;font-size:initial;font-family:Calibri,&#39;Slate Pro&#39;,sans-serif;color:rgb(31,73,125);text-align:initial;background-color:rgb(255,255,255)">


The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers… at least not visibly.


Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.


The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".


There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!


Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?


‎I hope you're seeing the issue now. Any suggestions?



Kind regards,
Olawale Olowu
wa…@xavierltd.com
Tel: 08075390014

From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All,


Trust everyone's doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I'm hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I'll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert 'Department' field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

  1. In Permission Manager, select 'Department' as condition for ‎Manager role in the relevant docs.

In the upgrade Permission Manager, if "Apply User Permission" is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don't particular User Property applied, you should check "Ignore User Permission" for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions


With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee's department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvKpcHdFLogZb_Z%3DpYbgD1WZZ%3DYJ6_6%3DBjG10OkWiK00g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.






You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820125919.5402755.90903.9568%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/F6E05D5D-63E5-46EE-92CE-0B93BDACA95F%40gmail.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com
‎Hi Rushabh, 

Thanks for the input. I however think that would be a very limited solution. Don't forget that the principles apply with most any document. Many organizations work with several documents that go through various approval processes. In version 3, it was fairly easy to map most processes ‎using a combination of workflow and permission manager.

I think you need something similar to the version 3 approach where we could give access based on a link within the docs matching user properties of certain roles


Kind regards,
Olawale ‎
From: Rushabh Mehta
Sent: Wednesday, August 20, 2014 2:04 PM
To: er...@googlegroups.com
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Maybe this can be linked directly to the Department / Branch for Leave and Expenses. Maybe create a table where you can set employee and whether that employee is a leave / expense manager and that would define the rules for approval...




On 20-Aug-2014, at 6:29 pm, wa...@xavierltd.com wrote:

Hi Umair,

Yes, the 2 conditions you mentioned have b‎een set accordingly 

No, the user properties for manager does not have employees defined because as per your outline, the final approving authority (ie GM/CEO) is the one set as approving authority. 

I do not welcome the idea of manually adding ‎employees to manager properties because it doesn't seem like a workable/sustainable solution. What it implies is that if a department (e.g Sales) has 100 employees, then we need to individually add 100 employee IDs to the manager's user permission‎s!

What of in a scenario where employees are transferred from one department to another (this happens quite often)? The system will still allow the former manager to see/approve expenses until the employee IDs are manually dele‎ted from one manager's profile and added to the other??

Why can't this just work like version 3 where you could simply set a cond‎ition for the manager to view docs for all employees whose department matches his own? 

This was a much more graceful solution and it had the added advantage that once an employee's department changes, the new manager automatically gets access to his docs and the former manager stops seeing them.


Kind regards,
Olawale ‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 1:29 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:
Hi Umair, 

Thanks for your reply. The ‎issue is at step 2 in your outline:

‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers... at least not visibly.

Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.

The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".

There should be a way to let the system override the 'From Employee' restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the 'From Employee' field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!

Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?

‎I hope you're seeing the issue now. Any suggestions?


Kind regards,
Olawale Olowu
wa...@xavierltd.com
Tel: 08075390014
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All, 


Trust everyone’s doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I’m hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I’ll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert ‘Department’ field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
 
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
 
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

 

  1. In Permission Manager, select ‘Department’ as condition for ‎Manager role in the relevant docs. 

In the upgrade Permission Manager, if “Apply User Permission” is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don’t particular User Property applied, you should check “Ignore User Permission” for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions

 

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee’s department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvKpcHdFLogZb_Z%3DpYbgD1WZZ%3DYJ6_6%3DBjG10OkWiK00g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.






You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820125919.5402755.90903.9568%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/F6E05D5D-63E5-46EE-92CE-0B93BDACA95F%40gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820135245.5402755.71966.9575%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.

‎Hi Umair, 

That sounds like an excellent idea! That might just be the way forward. How soon can you implement this? Its a desperately needed solution 

I'm excited about this already : )


Kind regards,
Olawale‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 2:18 PM
To: ERPNext User's Forum
Reply To: er...@googlegroups.com
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Or perhaps option of Role-wise "Ignore User Permission" will do it.

If we can Ignore User Permission check on "For Employee" field just for the Managers Role, there will be no need to create User Property for each Approver-Employee.

Currently "Ignore User Permission" option in the Customize form is applied for all the users.


On Wed, Aug 20, 2014 at 6:33 PM, Rushabh Mehta <rm...@gmail.com> wrote:
Maybe this can be linked directly to the Department / Branch for Leave and Expenses. Maybe create a table where you can set employee and whether that employee is a leave / expense manager and that would define the rules for approval...




On 20-Aug-2014, at 6:29 pm, wa...@xavierltd.com wrote:

Hi Umair,

Yes, the 2 conditions you mentioned have b‎een set accordingly 

No, the user properties for manager does not have employees defined because as per your outline, the final approving authority (ie GM/CEO) is the one set as approving authority. 

I do not welcome the idea of manually adding ‎employees to manager properties because it doesn't seem like a workable/sustainable solution. What it implies is that if a department (e.g Sales) has 100 employees, then we need to individually add 100 employee IDs to the manager's user permission‎s!

What of in a scenario where employees are transferred from one department to another (this happens quite often)? The system will still allow the former manager to see/approve expenses until the employee IDs are manually dele‎ted from one manager's profile and added to the other??

Why can't this just work like version 3 where you could simply set a cond‎ition for the manager to view docs for all employees whose department matches his own? 

This was a much more graceful solution and it had the added advantage that once an employee's department changes, the new manager automatically gets access to his docs and the former manager stops seeing them.


Kind regards,
Olawale ‎
From: Umair Sayyed
Sent: Wednesday, August 20, 2014 1:29 PM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

Replies below.


On Wed, Aug 20, 2014 at 3:17 PM, <wa...@xavierltd.com> wrote:

Hi Umair, 


Thanks for your reply. The ‎issue is at step 2 in your outline:


‎2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.

                                                                                                                                 <div style="width:100%;font-size:initial;font-family:Calibri,'Slate Pro',sans-serif;color:rgb(31,73,125);text-align:initial;background-color:rgb(255,255,255)">


The last part of your statement does not happen in version 4! The user properties defined based on Department do NOT get applied on managers… at least not visibly.


Please verify two things:
  1. User Property should be set for Manager on Department.
  2. In Role Permission Manager, "Apply User Permission" should be checked for the Manager's role.


The reason could be because those documents already have permissions that restrict users with other fields like ‎"From Employee".


There should be a way to let the system override the ‘From Employee’ restriction for a particular role (in this case, manager role) without ignoring user permissions for that field. If user permission for the ‘From Employee’ field is ignored then it means all employees would be able to view all Expenses which is obviously not what we want!


Ignoring Permission on "From Employee" field is not required, because User Property for Manager will be have Employees defined in it. Have you define User Permission for Manager - Employee?


‎I hope you’re seeing the issue now. Any suggestions?



Kind regards,
Olawale Olowu
wa…@xavierltd.com
Tel: 08075390014

From: Umair Sayyed
Sent: Wednesday, August 20, 2014 6:59 AM
To: ERPNext User's Forum
Subject: Re: [erpnext-user-forum] Permission Manager Issue

Hello Wale,

My inline replies below.


On Tue, Aug 19, 2014 at 5:09 PM, <wa...@xavierltd.com> wrote:

‎Hi All, 


Trust everyone’s doing great today. While w‎orking with the new version (4) of our beloved ERPNext, I encountered an issue which I’m hoping someone else has been able to find a way around.


‎Question: how do you get a user with a certain role to see only a portion of a list which is relevant to them? I’ll give a common scenario below.


Managers of various departments need to give authorization for several documents (Expense Claims, Leave Applications etc) before it gets to the final approver which could be a General Manager or CEO.


In your previous version, what did Employee select for Approver in their Leave Application or Expense Claim? Was it immediate Manager of employee, or GM/CEO who ultimately approves it? As per the standard approval system Expense Claim and Leave Application, only Approver as defined by the Employee can Approve or Reject request made by Employee.


http://imgur.com/xKb23jt
http://imgur.com/dS5eSRa


In version 3, all we needed to do was:


  1. Insert ‘Department’ field into relevant docs.

You can insert Custom Field linked with Department master.

http://imgur.com/ReCIzZY
 
2. Create 'Manager' role.

Assigning role of "Expense Approver" and "Leave Approver" will be suffice, if that manager has authority for Approving or Rejecting.
 
  1. Add Department value (e.g Sales, HR, Logistics)‎ in user properties for all employees .

You should create User Property to define Department for each Employee. User Property to also be created for Manager listing Department they will have access to.


http://imgur.com/6gR0Fst
http://imgur.com/CwqMuew

 

  1. In Permission Manager, select ‘Department’ as condition for ‎Manager role in the relevant docs. 

In the upgrade Permission Manager, if “Apply User Permission” is checked in Role Permission Manage for specific Role, all the User Property created for that user will be applied.


If you don’t particular User Property applied, you should check “Ignore User Permission” for that field from Customize Form. Check following link for more information on this.

https://erpnext.com/user-guide/setting-up/permissions/user-permissions

 

With these steps, each manager would be able to view and manage documents from employees only within their departments/units. This also ensured that once an employee’s department was changed, his new manager would automatically have access to his documents.


If you want multiple level approval system working (Employee-Manager-CEO/GM) using standard approval system only, following steps should be followed:
  1. Employee should select CEO/GM as approver in their Leave Application or Expense Claim.
  2. The Expense or Leave Approver (or Manager in your case) should be given only read permission on Expense Claims and Leave Applications respectively. After reviewing, they will escalate Claim or Leave request to CEO/GM. The User Properties define based on Department will be applied on managers.
  3. Since CEO/GM who will be defined as Approver already will Approve/Reject request submitted by Employee.


How is this achieved in version 4?




Kind regards,
Olawale




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140819113922.5427332.36628.9530%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.





Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvZ6frxbxFoVpjf5j88ZzQiTYmdeJBecE%3Dp-9%3DpOBV1pg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.





You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820094738.5402755.41372.9555%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,

Umair Sayyed
www.erpnext.com




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAvKpcHdFLogZb_Z%3DpYbgD1WZZ%3DYJ6_6%3DBjG10OkWiK00g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.






You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820125919.5402755.90903.9568%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/F6E05D5D-63E5-46EE-92CE-0B93BDACA95F%40gmail.com.

For more options, visit https://groups.google.com/d/optout.



--
Thanks and Regards,
Umair Sayyed
www.erpnext.com



You received this message because you are subscribed to the Google Groups “ERPNext User’s Forum” group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/CAJ33fAsKa5hohqqXZBySxtrYEzGu6J78AgppvKJ7TVRt7qhtrw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.




You received this message because you are subscribed to the Google Groups "ERPNext User's Forum" group.

To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-user-forum+un…@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-user-forum/20140820135752.5402755.45210.9577%40xavierltd.com.

For more options, visit https://groups.google.com/d/optout.