Okay, we are waiting for this!
@beingeek @wojosc
I have installed the add-on on ERPNext 15, I am a little bit confused. I am looking to mark Saturday as a half-working day. I created a weekly working hour, but when I save it, it changes the status to draft, and I couldnât figure out how to submit it to take effect.
I know about this probelm, but thought it should be fixed already. The Workday doctype should be submittable. Please check in Doctype â Workday if that is the case. A quick fix can be to create a property setter.
I have worked with the modul today. Please check this function:
Probably it is not necessary to create each record by hand but rather use this automation.
As I stated here , I couldnât submit Weekly Working Hours, which is required when you process workdays.
Oh, sorry, I got that mixed up.
maybe you need to check if you have permissions to perform the submit action via Role Permission Manager
Yeah, you were right. I think I need to assign those roles to the user. It would be best if such a thing were addressed in the HR Addon document.
But I am seeing glitches on the addon. I deployed ERPNext using podman, and sometimes some features of ERPNext donât work correctly after the installation of the HR Addon. I was having a hard time assigning the role to the user, but after multiple reloads, I could assign the role. But another issue occured, when I search for âWeekly working hourâ or anything related to HR Addon features, I am getting this:
Which version are you using? Using version-15 should be the one to chose.
Yeah, you were right, I have installed version-15 and after adding the role to submit the weekly working hours, it submitted successfully. Thanks
Tried creating Workday as you suggested, after clicking on Process Workday, I am receiving this error:
Something went wrong in Workday Creation: Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/hr_addon/hr_addon/hr_addon/doctype/workday/workday.py", line 524, in bulk_process_workdays workday.save() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 378, in save return self._save(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 400, in _save return self.insert() ^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 309, in insert self.run_before_save_methods() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1136, in run_before_save_methods self.run_method("validate") File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1007, in run_method out = Document.hook(fn)(self, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1367, in composer return composed(self, method, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1349, in runner add_to_return_value(self, fn(self, *args, **kwargs)) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1004, in fn return method_object(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/hr_addon/hr_addon/hr_addon/doctype/workday/workday.py", line 17, in validate self.set_actual_employee_log() File "/home/frappe/frappe-bench/apps/hr_addon/hr_addon/hr_addon/doctype/workday/workday.py", line 23, in set_actual_employee_log new_workday_dict = get_actual_employee_log(self.employee, self.log_date) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/hr_addon/hr_addon/hr_addon/doctype/workday/workday.py", line 285, in get_actual_employee_log new_workday = get_workday(employee_checkins, employee_default_work_hour, no_break_hours) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/frappe/frappe-bench/apps/hr_addon/hr_addon/hr_addon/doctype/workday/workday.py", line 381, in get_workday if hr_addon_settings.enable_default_break_hour_for_shorter_breaks: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'HRAddonSettings' object has no attribute 'enable_default_break_hour_for_shorter_breaks'
Do the migration and bench restart.
1 Like
Okay, thanks. It worked now, but the only reason I am using this add-on is to get a correct Monthly Attendance Sheet without marking Saturday as an early exit, since itâs a half-day.
I have some questions on this HR Addon.
-
Will it change the way Frappe HR shift works? So that it will be applied on the Monthly Attendance Sheet?
-
Is there a way to output a report that is similar to Monthly Attendance Sheet, including all employees? I saw the Work Hour Report, but I could only select one employee, which is not suitable for the HR Department to get a monthly attendance sheet.
Thank you
Great 
Although I not used this add-on and donât know too much about it what internally itâs doing, is it affecting the internal shifts or not. And the second point about report is that you can customisation and build the reports according to your needs.