Problem with 'More' button to create Purchase Order from Material Request

ERPNext Buying
,
1

Hello,

We have a use case where the user makes hundreds of Material Request and place single purchase order for one item at a time.

It was great to have this feature in v15. First, we create New Purchase Order and select ‘Get items from’ Material request. The popup comes to select the items.
We select 1. Select Material Request Item 2. The ‘submitted’ filter to see all the available items from hundreds of material requests. 3. Search the item code for which to make the Purchase order and select them

more-2
more-21347×647 63.7 KB

However, it shows all products only if the whole products are made visible first by clicking the ‘More’ button.

more-1
more-11339×630 60 KB

It is creating us serious problem now that the list is growing even bigger and the user has to click 5-20 times on more button to get the whole list visible.

To solve this, we got the following code in an app>public>js folder in a js file. It is removing the More button and showing the whole list.

frappe.ui.form.MultiSelectDialog = class MultiSelectDialog extends frappe.ui.form.MultiSelectDialog {
	// TODO: Add custom field to preselect page_length
	// use methods get_primary_filters() and get_fields()
	// frappe/frappe/public/js/frappe/form/multi_select_dialog.js
	get_result_fields() {
		const show_next_page = () => {
			this.doctype == "Material Request" ? this.page_length += 1000: this.page_length += 5;
			this.get_results();
		};
		return [
			{
				fieldtype: "HTML",
				fieldname: "results_area",
			},
			{
				fieldtype: "Button",
				fieldname: "more_btn",
				label: __("More"),
				click: show_next_page.bind(this),
			},
		];
	}
	init() {
		this.doctype == "Material Request" ? this.page_length = 1000: this.page_length = 20;
		this.child_page_length = 20;
		this.fields = this.get_fields();

		this.make();
	}
};

However, it is working in Dev server but fails to execute in the Production instance where the ‘More’ button is still visible even after performing bench build --app app-name, bench --site site-name migrate etc.

I would appreciate any guideline on this to remove this button and request the core DEV team of Frappe & ERPNext to make this button optional through a settings option. While this button might help save resources, those savings are negligible and an obstacle to achieve smooth operation.

In this context, I would also like to mention that the list view default 20/100/500 items should also be customizable through settings, because we have to make unnecessary clicks to make the view larger each and every time we visit most frequently used DocTypes (like Items, Purchase Order, Material Request etc.). There is an app for that but I failed to make it work for v15 a month ago:

Thanks in advance.

2

EDIT:

The above code was not working after creating more material requests. The ‘More’ button came back.

I will appreciate any clue/guideline on how to remove it.

Thanks.

3

Below is the working code I received from a very talented Dev from Kenya. It fetches 1000 material request at a time which is good enough to delay the appearance of More button unless it crosses 1000 (good number for us now):

frappe.ui.form.MultiSelectDialog = class MultiSelectDialog extends frappe.ui.form.MultiSelectDialog {
// TODO: Add custom field to preselect page_length
// use methods get_primary_filters() and get_fields()
// frappe/frappe/public/js/frappe/form/multi_select_dialog.js
init() {
this.parent_child_length = 1000; // USE THIS TO SET THE PAGE LENGTHS
this.page_length = this.parent_child_length;
this.child_page_length = this.parent_child_length;
this.fields = this.get_fields();

	this.make();
}

get_result_fields() {
	const show_next_page = () => {
		this.page_length += this.parent_child_length;
		this.get_results();
	};
	return [
		{
			fieldtype: "HTML",
			fieldname: "results_area",
		},
		{
			fieldtype: "Button",
			fieldname: "more_btn",
			label: __("More"),
			click: show_next_page.bind(this),
		},
	];
}

get_child_selection_fields() {
	const fields = [];
	if (this.allow_child_item_selection && this.child_fieldname) {
		const show_more_child_results = () => {
			this.child_page_length += this.parent_child_length;
			this.show_child_results();
		};
		fields.push({ fieldtype: "HTML", fieldname: "child_selection_area" });
		fields.push({
			fieldtype: "Button",
			fieldname: "more_child_btn",
			hidden: 1,
			label: __("More"),
			click: show_more_child_results.bind(this),
		});
	}
	return fields;
}

};