Problem with python float and frappe, how to handle?

kittiu · April 26, 2023, 1:07am

Everyone might know Python has this problem

2000-1780.2 = 219.79999999999995

And this effect some of the logic when we try to compare two numbers.

I do have this problem in HR and discuss change and propose to fix here, which I think round number before might be it.

github.com/frappe/hrms

fix: rounding error on set_total_advance_paid when return

frappe:develop ← kittiu:fix-set_total_advance_paid-rounding

opened 05:40AM - 31 Mar 23 UTC

kittiu

+1 -1

With case Advance / Return * Employee Advance = 2,000 * Expense Claim = 1,617.…20 + 113.20 (tax 7%) = 1,730.40 * Return with Journal Entry = 169.60 -----> ERROR "Return amount cannot be greater unclaimed amount" This is because when I look at the log, return_amount = 269.6 self.paid_amount = 2000 self.claimed_amount = **1730.404** ----> in Advance, it show **1730.40**, but in database it is 1730.404 ![image](https://user-images.githubusercontent.com/1973598/229032712-d91852f8-872f-483a-934c-6699d82ed956.png)

But I still wondering what is the best way to handle this kind of problem in Frappe.

Thank you