I have a long list of improvement proposal list, mainly for the frappe framework. Even though I created some PR and merged.
frappe:develop ← szuyxy:support_paste_multi_recs_in_childtable
opened 03:02AM - 10 Sep 18 UTC
How it works
1. Prepare the source data in Excel or text editor with each colum… n separated by tab,
case 1. first line as column header, both field name and label supported
case 2. no column header, the data will directly map to the visible columns
2. Drag to select the records , and copy (ctrl + C)
3. Make sure the child table is in edit mode(if needed click the Add Row button), place the cursor to the target input field of the child table, paste (ctrl + V)
Please read the [Pull Request Checklist](https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist) to ensure you have everything that is needed to get your contribution merged.
frappe:develop ← szuyxy:global_search_support_and
opened 12:48PM - 05 Jul 18 UTC
Motivation:
The current global search is a very powerful and killer feature whi… ch enable universally searching the whole ERP system by simple key words, it is more a kind of internal Google. so far so good, per my observation and study the forum discussion about global search, I identified an important missing feature, that is it only support search by single key word or using as default an OR logic to combine all the user input search text separated by space. for example if we have similar items with names as
apple ipad, apple iphone, sumsung ipad, sumsung phone etc, there is no way to pin point the specific item, because using either single key word or multi key words separated by space will result more results than expected, the other similar cases is that some times it is needed to search orders by the item names included in it or by all the tags assigned to it, the current global search can not handle this important use case.
Solution by this pull request
the user can use the AND operator (&) in the search text, e.g 'apple & ipad', then in the backend, two separate search into the global search help table will be executed, one for each search term, here apple and ipad respectively, then the 2 search results will be checked, only these records which exist in both search result (the AND logic) will be finally returned to the user(front end). it is quite straight forward. for more details, check the code.
support the user to use and operator (&) in the search text, to search target document by combined multi search term(key words separated by &, thus we can search purchase order by vendor name, the items purchased all together!
Please read the [Pull Request Checklist](https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist) to ensure you have everything that is needed to get your contribution merged.
frappe:develop ← szufisher:master
opened 12:46PM - 20 Jun 18 UTC
Pull-Request
- [v ] Have you followed the guidelines in our Contributing docu… ment?
- [ v] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
- [v] Have you lint your code locally prior to submission?
- [ v] Have you successfully run tests with your changes locally?
- [v] Does your commit message have an explanation for your changes and why you'd like us to include them?
- [ ] Docs have been added / updated
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Did you modify the existing test cases? If yes, why?
---
What type of a PR is this?
- [ ] Changes to Existing Features
- [ v] New Feature Submissions
- [ ] Bug Fix
- [ ] Breaking Change
---
- Motivation and Context (What existing problem does the pull request solve):
refer to this forum discussion post https://discuss.erpnext.com/t/new-feature-proposal-enable-search-user-tags-in-link-field-and-global-search/37596/2
- Related Issue:
- Screenshots (if applicable, remember, a picture tells a thousand words):
**Please don't be intimidated by the long list of options you've to fill. Try to fill out as much as you can. Remember, the more the information the easier it is for us to test and get your pull request merged** :grin:
frappe:develop ← szuyxy:create_all_dropship_po_for_so
opened 04:10PM - 27 Jul 18 UTC
Refer to issue https://github.com/frappe/erpnext/issues/15031
**Business case… **
- Sales order with multi items assigned to different suppliers
**As Is**
- by clicking the create purchase order custom menu item, there is popup window to force user select one supplier, system auto fetch all the data for the new drop ship purchase order and route to the new purchase order screen, waiting for user to further modify the order and click SAVE to create the final draft PO, for each supplier, the above mentioned steps need to be repeated
- if draft purchase orders already created for the supplier, click the create purchase order menu item and select the supplier again, system will create the purchase order again without any error message, only when trying to submit the purchase order, there is limit crossed error!
**To Be**
- Allow user to leave the supplier field empty, system creates multi draft drop ship purchase orders for all suppliers assigned to sales order items
- only the supplier by which the corresponding drop ship purchase orders(draft and submitted) not yet created will be available in the supplier drop down list
Fig1: Allow user leave the supplier field empty
Fig2: after multi purchase orders created, route to the list instead of the form view
Please read the pull request checklist to make sure your changes are merged: https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist
( converted to another PR, still open)
frappe:develop ← szuyxy:scan_barcode
opened 08:38AM - 06 Sep 18 UTC
How It Works
- Maintain barcode field in Item doctype
<img width="685" alt="… barcode item master" src="https://user-images.githubusercontent.com/12823863/45146102-bf096280-b1f4-11e8-89c4-295e3ec084a0.PNG">
- Scan barcode in target docs in form view on New / change mode
<img width="587" alt="material request barcode scan" src="https://user-images.githubusercontent.com/12823863/45146118-c7fa3400-b1f4-11e8-9db5-ea8bc2d4adbf.png">
target docs should have
- field items, field type as Table type
- items child table have fields: item_code and qty
A new scan barcode field above the items table will be added, scan the item barcode label,( ensure the carriage RETURN is attached as suffix in the scanner setting), or manual key in barcode then press ENTER), the program will auto fetch the item based on barcode, when first time scanning the material, it auto creates a new record at top of the items table with item_code and qty as 1, otherwise, the existing record will be changed by adding 1 to existing qty. no impact to opening existing submitted doc with non editable status.
Currently this new feature will be automatically enabled for the following standard doctypes ,
- Material Request
- Purchase Order
- Sales Order
- Purchase Receipt
- Delivery Note
- Stock Entry
- Purchase Invoice
- Sales Invoice
discussion thread
https://discuss.erpnext.com/t/new-feature-proposal-barcode-scan-to-create-update-records-in-child-table-useful-for-stock-movement-and-orders/33695/5
Please read the pull request checklist to make sure your changes are merged: https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist
I realized that single handed on new PR for all tasks : idea, spec, coding, testing, documentation is very challenging and time consuming, most of the times even result in TOTAL halt.
I would like to seek this opportunity to have my ideas/ new proposals supported by the foundation fund.
3 potential projects below
Currently, the core function frappe.get_list / frappe.get_all is a high level API to wrap raw SQL call to the database, which is extensively used by the list view and reports, there is already special logic to directly allow filtering by child table field, e.g filtering sales order by item_code field in items child table, we can use filtering arguments like this: filters={‘item_code’:‘xxx’}, it is also possible to fetch child table fields by either use the argument with_childnames or directly ad…
Dear szufisher,
I think benchmark the SAP authorization concept is a great idea. I’m the SAP basis admin and been familiar with the SAP authorization very well.
I’m not the developer, so I can’t give much input on the coding. But anything on sap authorization may give some help.
frappe:develop ← szufisher:develop
opened 02:17PM - 30 Jan 18 UTC
**Features added**
1. Create new/update existing document or execute python code when document created/saved/submitted/value changed, or specified method called
or scheduled time event:before or after certain days based on specified date field reached,
2. Execute python code per javascript calling convention
**Use Cases:**
1. Auto assign responsible person for new or updated task/order/issue etc
2. Auto create error log/to do /issue when certain documents created/changed under specific conditions
3. do customized validation check for custom doctypes: using frappe.throw(_('validation failure!'))
4. do customized handling:auto filling certain fields for custom doctypes
5. do customized complex server side logic for custom button: get items from , create subsequent documents, jump to related document etc
6. do required simple or complex customization on SaaS, which currently not possible!
7. do what you want per your creative idea!
**How to use it**
1. define custom server action
Action Type: with following options
Update Record: when event triggered, the doc(target document type per the link field, the current doc as default) will be updated,
to be updated fields are defined under the field mapping child table
Create New Record:when event triggered, a new doc of target document type will be created, fields are defined under the field mapping child table
Execute Python Code: when even triggered , the Python code will be called
Python Code Called By JS: the python code will be called via frappe.call from javascript, normally bound to custom button in form view.
Document Type: the document type by which to trigger the action,
Trigger On: when to trigger, with following options
New
Save
Submit
Cancel
Days After
Days Before
Value Change
Method
Custom
Trigger Method: when selected trigger on as Method, specify the method name here
Value Changed: when selected trigger on as Value change, specify the field (value change)
Reference Date : when selected trigger on as Days Before or Days After, specify the referenced date field
Days Before Or After: when selected trigger on as Days Before or Days After, specify the number of days
Condition: python expression, only the evaluated result is True, the action will be called
Code: the python code to be exectuted, when action type is Execute Python Code or Python Code Called By Client
Target Document Type: when action type is Update Record or Create New Record, default as the document type
Link Field: when action type is Update Record and target document type is not same as document type, the link field from the document type
Field Mapping
Field: the target field of the target document type
Type: Value, Formula
Value: if type is value, the field value, if type is formula, the python expression, just like the condition field
tips for python code and python expression
local context variable: doc, frappe, json,_ is available
internal function is not supported, thus def, return is not allowed, for passing input parameter and return result, use frappe.local.form_dict instead
special key custom_server_action_out is used for returning value from python code, for more details with samples refer to the relevant post in discuss.erpnext.com
How it works in the background technically
1. Added 2 new doctypes, referred to exsting email alert feature, instead of updating one field with fixed value only,added a child table to allow assign
multi fields for new / update document, enhanced field value assignment to support python expression, also added the possibility to execute python code for
more complicated cases
1.1 custom server action
1.2 custom server action field
2. added one new version of the safe_eval (based on Odoo), whitelisted opcodes are defined, thus to safeguard the security of the customized python code
3. Updated model.document.py, added hooks for the custom server action , like existing web hooks.
4. added 2 handlers in frappe/custom/doctype/custom_server_aciton.__init__ run_custom_server_action and run_custom_server_action_by_js.