Purchase Order Status inconsistent when creating via REST API

tgraupne · March 4, 2024, 9:20pm

Hey everyone

Again, I am hoping for some feedback and help because I find it hard to understand how ERPNext actually works and what might cause this inconsistency.

In this current scenario, I want to work with ERPNext only by using the REST API and I want to create Purchase Orders.

This is how I create my Purchase Orders:

po_endpoint = f'{erpnext_url}/api/resource/Purchase Order'
po_data = {
    "supplier": "Primary Processor ABC",
    "docstatus": 1,
    "items": [
        {
            "item_code": "BB",
            "custom_content": "MAT-ABS-5mm",
            "schedule_date": schedule_date,
            "qty": 1.0,
        },
    ]
}

All good, I get HTTP 200 and a Purchase Order id: po_id

But now it gets weird. When I look at the list view, the POs I create have the status To Receive and Bill, as expected, right?

But after I queried them again via the REST API, I noticed that their status was actually still Draft. Moreover, if I switched to the Report View, the status was displayed as Draft.

What could be the reason for this?

I am already using "docstatus";1 when creating the po.

Manan_Shah · March 5, 2024, 6:09am

Can you make a GET API call for the document created and check the status returned in the response?

I have a feeling somehow db.commit is not executed when you create a document using POST method even if you send docstatus = 1 , you may have to update the status using UPDATE method in subsequent call if required.

avc · March 5, 2024, 7:36am

Hi @tgraupne:

Don’t pass status.

After doc creation use this

POST
https://yoursite.com/api/resource/Purchase%20Order/PUR-ORD-2024-00012

{
    "run_method": "submit"
}

Check this video for further reference:

Hope this helps.

tgraupne · March 5, 2024, 7:54am

Thank you for your feedback @Manan_Shah.

Can you make a GET API call for the document created and check the status returned in the response?

After creating the Purchase Order like described about, I checked the status right away and it was Draft.

Thereafter, I did the following:

response = login_session.put(
  f"{po_endpoint}/{po_id}",
  json={"docstatus": 1}
)

Status was still Draft and docstatus stayed 1.

Thereafter, I tried the following:

response = login_session.put(
  f"{po_endpoint}/{po_id}",
  json={"status": 'To Receive and Bill'}
)

This was not possible and I got an HTTP 417.

@avc thank you for your feedback as well. I will watch the video after sending the message. I already tried your suggestion. I executed the following POST request:

response = login_session.post(
  f"{po_endpoint}/{po_id}",
  json={"run_method": "submit"}
)

I got back an HTTP 200. However, a subsequent GET request as well as the Report View in ERPNext still show status Draft.

avc · March 5, 2024, 8:02am

Hi:

It’s working well …
Which version are you using?

tgraupne · March 5, 2024, 9:13am

@avc I am using

frappe "version": "14.64.0"
erpnext "version": "14.61.3"

I was wondering if I could try the whitelisted function:

@frappe.whitelist()
def update_status(status, name):
	po = frappe.get_doc("Purchase Order", name)
	po.update_status(status)
	po.update_delivered_qty_in_sales_order()

However, I don’t even know what would be the correct status.

I would assume that there is some kind of an ENUM somewhere, explicitly defining the states a Purchase Order can be in but I wasn’t able to find it in the erpnext source code.

tgraupne · March 5, 2024, 10:06am

Manually updating the status or a Purchase Order worked by using the whitelisted method:

update_status_method_endpoint = f'{erpnext_url}/api/method/erpnext.buying.doctype.purchase_order.purchase_order.update_status'

pr_data = {
    "status": "To Receive and Bill",
    "name": po_id
}

response = login_session.post(update_status_method_endpoint, json=pr_data)

assert response is not None
assert response.status_code == 200

However, I still don’t understand the inconsistent status visualization in List View and Report View. Moreover, I was expecting that Purchase Orders would be submitted correctly on HTTP POST by providing docstatus:1 during creation, at least this is what the community has tough me.

I created a bug report on GitHub:

github.com/frappe/erpnext

Purchase Order Status inconsistent when creating via REST API

opened 09:37AM - 05 Mar 24 UTC

tgraupne

bug

### Information about bug When creating a `Purchase Order` via REST API the `…Purchase Order` List View shows the `Status = To Receive and Bill`. <img width="1281" alt="image" src="https://github.com/frappe/erpnext/assets/7671391/9ab540f2-ecb0-4fc5-9e76-6a2240740b84"> However, when one switches to the Report View or queries the `Purchase Order` again via REST, it is shown as `Status = Draft`. <img width="1282" alt="image" src="https://github.com/frappe/erpnext/assets/7671391/041d3396-1689-4f54-a812-7935956d8e40"> The following REST API call was used to create the `Purchase Order`: **For login:** ```python def login_session(password): session = requests.Session() login_url = 'http://site1.localhost:8000/api/method/login' headers = { 'Accept': 'application/json', 'Content-Type': 'application/json', } payload = { 'usr': 'Administrator', 'pwd': password } response = session.post(login_url, json=payload, headers=headers) assert response.status_code == 200 yield session # This will be returned to the test function # Teardown session.get('http://site1.localhost:8000/api/method/logout') ``` POST `Purchase Order`: ```python def test_create_purchase_order(login_session, erpnext_url, schedule_date): po_endpoint = f'{erpnext_url}/api/resource/Purchase Order' data = { "supplier": "Primary Processor ABC", "docstatus": 1, "items": [ { "item_code": "BB", "schedule_date": schedule_date, "qty": 1.0, }, ] } response = login_session.post(po_endpoint, json=data) assert response is not None assert response.status_code == 200 json_response = response.json() assert 'data' in json_response ``` After asking for help in the frappe forum, we already tried the following to "submit" the document again: ```python po_endpoint = f'{erpnext_url}/api/resource/Purchase Order{po_id}' data = { "run_method": "submit" } response = login_session.post(po_endpoint, json=data) assert response is not None assert response.status_code == 200 ``` Unfortunately, without luck. Hence, we are asking ourselves, what might be the difference between creating a `Purchase Order` in UI and REST API and why does the UI show this inconsistent state? ### Module buying ### Version frappe "version": "14.64.0" erpnext "version": "14.61.3" ### Installation method docker ### Relevant log output / Stack trace / Full Error Message. _No response_

avc · March 5, 2024, 10:21am

Note that status is different that docstatus
Use submit method as suggested above.

tgraupne · March 5, 2024, 10:35am

Hey @avc , thanks again for your feedback.

Note that status is different that docstatus
Use submit method as suggested above.

I am aware of this, thank you

And, I already tried suggestion regarding:

POST
https://yoursite.com/api/resource/Purchase%20Order/PUR-ORD-2024-00012
{
“run_method”: “submit”
}

Unfortunately, I was not helping in my case.

Moreover, regardless of the correct follow up method to the initial POST request to create the Purchase Order, the main question still is, why are List View and Report View showing different things in their respective Status column?

avc · March 5, 2024, 1:08pm

Hi @tgraupne:

Before submit:
status = “Draft”
docstatus = 0

After submit,
status = “To Receive and Bill”
docstatus = 1

It’s your requirement, right?
Working in list view as well report view …

Tried on v15, maybe v14 issue …
BTW … if you are connecting from Python, explore this:

brian_pond · March 5, 2024, 6:50pm

That “shouldn’t” be possible.

Are you able to query the SQL tables themselves, and pull the values for 'status' and 'docstatus'?

What you’re describing almost feels like a SQL rollback. Something like:

Send the HTTP Post
Web server replies with 200
Web server fails to execute a SQL commit.
Data reverts to original state before the call.