[Release Notes] ERPNext Version 13 has been released

scdarva · April 23, 2021, 7:01am

Thank you after doing this in tabModule Def and tabDoctype it started going!

But soon stopped at

Executing erpnext.patches.v13_0.healthcare_lab_module_rename_doctypes in site1.local (_1bd3e0294da19198)
Traceback (most recent call last):
File “/usr/lib/python3.6/runpy.py”, line 193, in _run_module_as_main
“main”, mod_spec)
File “/usr/lib/python3.6/runpy.py”, line 85, in _run_code
exec(code, run_globals)
File “/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py”, line 101, in
main()
File “/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py”, line 18, in main
click.Group(commands=commands)(prog_name=‘bench’)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 764, in call
return self.main(*args, **kwargs)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 717, in main
rv = self.invoke(ctx)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/core.py”, line 555, in invoke
return callback(*args, **kwargs)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/click/decorators.py”, line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/commands/init.py”, line 27, in _func
ret = f(frappe._dict(ctx.obj), *args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/commands/site.py”, line 300, in migrate
skip_search_index=skip_search_index
File “/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py”, line 67, in migrate
frappe.modules.patch_handler.run_all(skip_failing)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 41, in run_all
run_patch(patch)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 30, in run_patch
if not run_single(patchmodule = patch):
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 71, in run_single
return execute_patch(patchmodule, method, methodargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 91, in execute_patch
frappe.get_attr(patchmodule.split()[0] + “.execute”)()
File “/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v13_0/healthcare_lab_module_rename_doctypes.py”, line 41, in execute
frappe.db.sql(“”“UPDATE tabNormal Test Result SET lab_test_name = test_name”“”)
File “/home/frappe/frappe-bench/apps/frappe/frappe/database/database.py”, line 152, in sql
self._cursor.execute(query)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/cursors.py”, line 170, in execute
result = self._query(query)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/cursors.py”, line 328, in _query
conn.query(q)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/connections.py”, line 517, in query
self._affected_rows = self._read_query_result(unbuffered=unbuffered)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/connections.py”, line 732, in _read_query_result
result.read()
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/connections.py”, line 1075, in read
first_packet = self.connection._read_packet()
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/connections.py”, line 684, in _read_packet
packet.check_error()
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/protocol.py”, line 220, in check_error
err.raise_mysql_exception(self._data)
File “/home/frappe/frappe-bench/env/lib/python3.6/site-packages/pymysql/err.py”, line 109, in raise_mysql_exception
raise errorclass(errno, errval)
pymysql.err.InternalError: (1054, “Unknown column ‘test_name’ in ‘field list’”)

Seems this update aint gonna be easy! But thank you very much nonetheless!

akurungadam · April 23, 2021, 7:03am

This was fixed last day, please pull again and try?

Thanks

scdarva · April 23, 2021, 7:05am

In version-13 or other branch?

akurungadam · April 23, 2021, 7:06am

oops, it was on develop

scdarva · April 23, 2021, 7:07am

So I would have to wait or is there a way to bypass (with a fix, that wouldnt break it in long term)?

akurungadam · April 23, 2021, 7:10am

You can skip it by commenting out that patch for now

scdarva · April 23, 2021, 7:14am

I downloaded individual patch from develop and put in the patches folder and it worked!
Thank you very much!

Sven_Morgenstern · April 23, 2021, 11:39am

May I jump in here?
I was running into the exact same problem as you did while updating from 12 to 13. Could you let me know where you downloaded the patch and where you put it?

scdarva · April 23, 2021, 11:57am

Of course.
I downloaded a patch from develop branch
this patch exactly
https://github.com/frappe/erpnext/commit/c21ce42559edba387f9959f2b502dc493afb1fc0
which is this file

github.com

frappe/erpnext/blob/c21ce42559edba387f9959f2b502dc493afb1fc0/erpnext/patches/v13_0/healthcare_lab_module_rename_doctypes.py

from __future__ import unicode_literals
import frappe
from frappe.model.utils.rename_field import rename_field

def execute():
	if frappe.db.exists('DocType', 'Lab Test') and frappe.db.exists('DocType', 'Lab Test Template'):
		# rename child doctypes
		doctypes = {
			'Lab Test Groups': 'Lab Test Group Template',
			'Normal Test Items': 'Normal Test Result',
			'Sensitivity Test Items': 'Sensitivity Test Result',
			'Special Test Items': 'Descriptive Test Result',
			'Special Test Template': 'Descriptive Test Template'
		}

		frappe.reload_doc('healthcare', 'doctype', 'lab_test')
		frappe.reload_doc('healthcare', 'doctype', 'lab_test_template')

		for old_dt, new_dt in doctypes.items():
			if not frappe.db.table_exists(new_dt) and frappe.db.table_exists(old_dt):

This file has been truncated. show original

and I put it in
~/frappe-bench/apps/erpnext/erpnext/patches/v13_0
~/frappe-bench/ is my bench location yours could be different.
after overwriting the existing file. run
bench update --patch
After a succesful update install, update it again, it will throw a warning, that your erpnext is different from the repository, just select to ignore your frappe select everything like it is in repository. (as the patch has run, it wont be needed anymore)
If you have any problem, say, I’ll try to help from my journey to v13

Sven_Morgenstern · April 23, 2021, 12:54pm

That helped me a lot! Thank you very(!) much and have a nice weekend.
I hope that someday I’ll be able to contribute something back to the open source community.

Francisco_Buendia · April 24, 2021, 8:39pm

“Delete all” button at tables doesn’t apply changes to some docs.
Anyone else having this issue?

https://github.com/frappe/erpnext/issues/25469

dipalivaddoriya · April 26, 2021, 7:51am

Trying to Update ERPNEXT from V12.20.2 to V13

Getting error on
bench switch-to-branch version-13 frappe erpnext --upgrade

bench not working after this command.
Recent Traceback of Commands

Traceback (most recent call last):

File “/usr/lib/python3.5/runpy.py”, line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File “/usr/lib/python3.5/runpy.py”, line 109, in _get_module_details
import(pkg_name)
File “/home/frappe/frappe-bench/apps/frappe/frappe/init.py”, line 372
print(f"Message: {strip_html_tags(out.message)}")

SyntaxError: invalid syntax

Traceback (most recent call last):
File “/usr/lib/python3.5/runpy.py”, line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File “/usr/lib/python3.5/runpy.py”, line 109, in _get_module_details
import(pkg_name)
File “/home/frappe/frappe-bench/apps/frappe/frappe/init.py”, line 372
print(f"Message: {strip_html_tags(out.message)}")

SyntaxError: invalid syntax

gurshish · April 26, 2021, 9:00am

This is a user permission issue for some reason as you give the user dashboard roles it reappears

shrikant9867 · April 28, 2021, 1:40pm

Then How to resolve the above … where am I missing?

uzumaki_naruto · April 29, 2021, 9:17am

I followed the same thing and overwrite the file inside patches. After doing so the update was successful but the login page is now messed up. I don’t understand how to fix it. Can you help me. Here is a screenshot of how it looks like now.

As you can see mainly the css of this page is affected

pss · April 29, 2021, 4:05pm

Just out of curiosity, when will the production ERPNext VM image be updated from v12 to v13?

Download EPRNext VM (erpnext.org)

Frost_Bread · April 29, 2021, 11:57pm

I am having the same problem for payment reconciliation - this is not working for V13. Has there been any solution? Nothing shows in the Invoice_number drop-down list.

mujeerhashmi · April 30, 2021, 12:01am

May be this is the fix you are looking for.

gsarunk · May 2, 2021, 3:44am

V13 update fails with frappe.exceptions.LinkValidationError: Could not find Report: E-Invoice Summary

Trying to upgrade and getting into the above error. Tried frappe.reload_doc(“regional”, “doctype”, “e_invoice_settings”, force=True) and followed by frappe.db.commit()

Still the same error.

gsarunk · May 2, 2021, 4:36am

@nabinhait could you please help resolving this. This happens in almost all of my sites.