Release v12.2.3 not fetched when update bench

Akram_Mutaher · December 11, 2019, 5:36pm

After running bench update my bench still in

ERPNext: v12.2.2 (version-12)

Frappe Framework: v12.0.20 (version-12)

Akram_Mutaher · December 13, 2019, 1:25pm

any help here

clarkej · December 13, 2019, 2:09pm

Try a search on ‘bench update stuck’ for ideas?

If you post the output that may give clues?

edit: See also "Landed Cost Voucher on submit" Debit and Credit not equal for Purchase Invoice #PINV-01267-1. Difference is 420.0 - #3 by Majid_Ejaz

Akram_Mutaher · December 13, 2019, 3:33pm

Production mode
Built js/moment-bundle.min.js
Built js/libs.min.js

Building frappe assets…

Built js/dialog.min.js
Built js/modules.min.js
Built js/social.min.js
Built css/frappe-rtl.css
Built css/printview.css
Built js/web_form.min.js
Built js/chat.js
Built js/list.min.js
Built css/form.min.css
Built css/module.min.css
Built frappe/css/email.css
Built css/report.min.css
Built css/list.min.css
Built css/frappe-chat-web.css
Built css/web_form.css
Built css/desk.min.css
Built js/barcode_scanner.min.js
Built js/bootstrap-4-web.min.js
Built js/frappe-web.min.js
Built js/desk.min.js
Built js/frappe-recorder.min.js
Built css/frappe-web-b4.css
Built js/control.min.js
Built js/form.min.js
Built js/data_import_tools.min.js
Built js/report.min.js
Done in 50.349s

Building erpnext assets…

Built js/erpnext-web.min.js
Built css/marketplace.css
Built css/erpnext.css
Built js/item-dashboard.min.js
Built js/erpnext.min.js
Built css/erpnext-web.css
Built js/marketplace.min.js
Done in 16.962s
Done in 69.84s.
INFO:bench.utils:sudo supervisorctl restart frappe-bench-workers: frappe-bench-web:
frappe-bench-workers:frappe-bench-frappe-schedule: stopped
frappe-bench-workers:frappe-bench-frappe-default-worker-0: stopped
frappe-bench-workers:frappe-bench-frappe-short-worker-0: stopped
frappe-bench-workers:frappe-bench-frappe-long-worker-0: stopped
frappe-bench-web:frappe-bench-node-socketio: stopped
frappe-bench-web:frappe-bench-frappe-web: stopped
frappe-bench-workers:frappe-bench-frappe-schedule: started
frappe-bench-workers:frappe-bench-frappe-default-worker-0: started
frappe-bench-workers:frappe-bench-frappe-long-worker-0: started
frappe-bench-workers:frappe-bench-frappe-short-worker-0: started
frappe-bench-web:frappe-bench-frappe-web: started
frappe-bench-web:frappe-bench-node-socketio: started

Bench: Deployment tool for Frappe and ERPNext (https://erpnext.org).
Open source depends on your contributions, so please contribute bug reports, patches, fixes or cash and be a part of the community

frappe@vmi301736:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20
frappe@vmi301736:~/frappe-bench$

clarkej · December 13, 2019, 4:40pm

So update does not pull erpnext and frappe from the repository, you should expect to see something like this:

INFO:bench.app:pulling frappe
INFO:bench.utils:git fetch --all
Fetching upstream
Fetching origin

Your logs/* may give clues to the source of the problem.

You may need to uninstall and reinstall those apps - or even uninstall and reinstall bench for example Bench not working

Akram_Mutaher · December 13, 2019, 5:27pm

frappe@vmi301736:~/frappe-bench$ bench update
INFO:bench.utils:updating bench
INFO:bench.utils:git pull
Already up-to-date.
INFO:bench.utils:./env/bin/pip install Pillow
Requirement already satisfied: Pillow in ./env/lib/python3.5/site-packages (6.1.0)
Backing up sites...
INFO:bench.app:pulling frappe
INFO:bench.utils:git pull  upstream version-12
From https://github.com/frappe/frappe
 * branch            version-12 -> FETCH_HEAD
Already up-to-date.
INFO:bench.utils:find . -name "*.pyc" -delete
INFO:bench.app:pulling erpnext
INFO:bench.utils:git pull  upstream version-12
From https://github.com/frappe/erpnext
 * branch            version-12 -> FETCH_HEAD
Already up-to-date.
INFO:bench.utils:find . -name "*.pyc" -delete
Updating Python libraries...
INFO:bench.utils:./env/bin/pip install -q -U pip
INFO:bench.utils:/usr/local/bin/pip3 install --user -q -U -r /home/frappe/.bench/requirements.txt
INFO:bench.app:installing frappe
INFO:bench.utils:./env/bin/pip install -q -U -e ./apps/frappe
INFO:bench.app:installing erpnext
INFO:bench.utils:./env/bin/pip install -q -U -e ./apps/erpnext
Updating node packages...
INFO:bench.utils:yarn install
yarn install v1.17.3
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.43s.
INFO:bench.utils:yarn install
yarn install v1.17.3
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.93s.
Patching sites...


Generating Website Theme Files...
Compiling Python Files...
INFO:bench.utils:bench build
yarn run v1.17.3
$ FRAPPE_ENV=production node rollup/build.js
Production mode
✔ Built js/moment-bundle.min.js
✔ Built js/libs.min.js

Building frappe assets...

✔ Built js/modules.min.js
✔ Built js/dialog.min.js
✔ Built js/social.min.js
✔ Built css/frappe-rtl.css
✔ Built css/printview.css
✔ Built js/web_form.min.js
✔ Built js/list.min.js
✔ Built js/chat.js
✔ Built css/module.min.css
✔ Built css/form.min.css
✔ Built css/report.min.css
✔ Built frappe/css/email.css
✔ Built css/list.min.css
✔ Built css/frappe-chat-web.css
✔ Built css/web_form.css
✔ Built js/barcode_scanner.min.js
✔ Built css/desk.min.css
✔ Built js/bootstrap-4-web.min.js
✔ Built js/frappe-recorder.min.js
✔ Built js/desk.min.js
✔ Built js/frappe-web.min.js
✔ Built css/frappe-web-b4.css
✔ Built js/control.min.js
✔ Built js/form.min.js
✔ Built js/data_import_tools.min.js
✔ Built js/report.min.js
✨  Done in 52.087s

Building erpnext assets...

✔ Built js/erpnext-web.min.js
✔ Built css/marketplace.css
✔ Built css/erpnext.css
✔ Built js/item-dashboard.min.js
✔ Built js/erpnext.min.js
✔ Built css/erpnext-web.css
✔ Built js/marketplace.min.js
✨  Done in 17.739s
Done in 71.62s.
INFO:bench.utils:sudo supervisorctl restart frappe-bench-workers: frappe-bench-web:
frappe-bench-workers:frappe-bench-frappe-schedule: stopped
frappe-bench-workers:frappe-bench-frappe-long-worker-0: stopped
frappe-bench-workers:frappe-bench-frappe-default-worker-0: stopped
frappe-bench-workers:frappe-bench-frappe-short-worker-0: stopped
frappe-bench-web:frappe-bench-node-socketio: stopped
frappe-bench-web:frappe-bench-frappe-web: stopped
frappe-bench-workers:frappe-bench-frappe-schedule: started
frappe-bench-workers:frappe-bench-frappe-default-worker-0: started
frappe-bench-workers:frappe-bench-frappe-long-worker-0: started
frappe-bench-workers:frappe-bench-frappe-short-worker-0: started
frappe-bench-web:frappe-bench-frappe-web: started
frappe-bench-web:frappe-bench-node-socketio: started
________________________________________________________________________________
Bench: Deployment tool for Frappe and ERPNext (https://erpnext.org).
Open source depends on your contributions, so please contribute bug reports, patches, fixes or cash and be a part of the community

frappe@vmi301736:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20
frappe@vmi301736:~/frappe-bench$

clarkej · December 13, 2019, 6:18pm

My guess is the issue seems to be with git - have you made any local changes?

Say in apps/erpnext run git fetch and also git branch -a and post the result?

Akram_Mutaher · December 13, 2019, 6:32pm

frappe@vmi301736:~/frappe-bench/apps/erpnext$ git fetch
remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1), done.
remote: Total 1 (delta 0), reused 1 (delta 0), pack-reused 0
Unpacking objects: 100% (1/1), done.
From GitHub - frappe/erpnext: Free and Open Source Enterprise Resource Planning (ERP)

[new tag] v12.2.0 → v12.2.0
[new tag] v12.2.1 → v12.2.1
[new tag] v12.2.2 → v12.2.2
[new tag] v12.2.3 → v12.2.3
frappe@vmi301736:~/frappe-bench/apps/erpnext$ git branch -a
version-12
remotes/upstream/version-12

Akram_Mutaher · December 13, 2019, 6:34pm

my local changes already committed

Majid_Ejaz · December 13, 2019, 6:54pm

Here is the link to the video. Please help us with problem. Thanks

clarkej · December 13, 2019, 7:18pm

Perhaps your version-12 branch is detached from HEAD?

Here for example my develop branch is attached to HEAD -

frappe@ubuntu:~/frappe-bench/apps/erpnext$ git branch -a
  develop
* master
  remotes/upstream/HEAD -> upstream/develop
  remotes/upstream/develop
...
  remotes/upstream/version-11
  remotes/upstream/version-11-hotfix
  remotes/upstream/version-12
  remotes/upstream/version-12-hotfix

Learn more here

Please note here what you do to fix this - that will be a reminder that will serve the community too thanks!

Akram_Mutaher · December 13, 2019, 8:29pm

I tried update more than one server the same issue in all, I think there is problem in release v12.2.3 because all previous releases updated smoothly.

MartinHBramwell · December 13, 2019, 11:58pm

I am also experiencing this issue.

erpnext@mine:~$ cd frappe-bench
erpnext@mine:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20
erpnext@mine:~/frappe-bench$ cd apps/erpnext
erpnext@mine:~/frappe-bench/apps/erpnext$ git fetch;
erpnext@mine:~/frappe-bench/apps/erpnext$ git branch -a;
* version-12
  remotes/upstream/version-12
erpnext@mine:~/frappe-bench/apps/erpnext$ cat .git/config 
[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "upstream"]
	url = https://github.com/frappe/erpnext
	fetch = +refs/heads/version-12:refs/remotes/upstream/version-12
[branch "version-12"]
	remote = upstream
	merge = refs/heads/version-12
erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
erpnext@mine:~/frappe-bench/apps/erpnext$

Any and all hints towards solving this gratefully received.

Note

Installation method was:

    sudo -Au ${PRD_ERPHOST_USR} wget -nc https://raw.githubusercontent.com/frappe/bench/master/playbooks/install.py;
    sudo -AH python3 install.py --production \
        --site ${PRD_ERPNEXT_SITE} \
        --user ${PRD_ERPHOST_USR} \
        --mysql-root-password ${PRD_ERPHOST_PWD} \
        --admin-password ${PRD_ERPHOST_PWD} \
        --bench-name ${NEWBENCH}

MartinHBramwell · December 14, 2019, 3:43pm

Some further experimentation below.

The end result is, i think, the same kind of Python version clashes that seem to frustrate installing manually (ie; not using install.py).

Initial version check:

erpnext@mine:~/frappe-bench$ cd /apps/frappe;
erpnext@mine:~/frappe-bench/apps/frappe$ git branch -a
* version-12
  remotes/upstream/version-12

erpnext@mine:~/frappe-bench/apps/frappe$ cd ../erpnext
erpnext@mine:~/frappe-bench/apps/erpnext$ git branch -a
* version-12
  remotes/upstream/version-12

erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout master
error: pathspec 'master' did not match any file(s) known to git.

Killing the erpnext app and cloning the whole repo:

erpnext@mine:~/frappe-bench/apps/erpnext$ cd ..
erpnext@mine:~/frappe-bench/apps$ rm -fr erpnext/

erpnext@mine:~/frappe-bench/apps$ git clone git@github.com:it-iridium-blue/erpnext.git
Cloning into 'erpnext'...
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 313506 (delta 2), reused 0 (delta 0), pack-reused 313495
Receiving objects: 100% (313506/313506), 787.62 MiB | 5.47 MiB/s, done.
Resolving deltas: 100% (240392/240392), done.
Checking out files: 100% (5975/5975), done.

erpnext@mine:~/frappe-bench/apps$ cd erpnext/
erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout master
Branch 'master' set up to track remote branch 'master' from 'origin'.
Switched to a new branch 'master'

erpnext@mine:~/frappe-bench/apps/erpnext$ cd ../..
erpnext@mine:~/frappe-bench$ bench version
erpnext 11.1.49
frappe 12.0.20

erpnext@mine:~/frappe-bench$ cd apps/erpnext/
~/frappe-bench/apps/erpnext ~/frappe-bench

erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout develop
Switched to branch 'develop'
Your branch is up to date with 'origin/develop'.

erpnext@mine:~/frappe-bench/apps/erpnext$ cd ../..
~/frappe-bench
erpnext@mine:~/frappe-bench$ bench version
erpnext 12.x.x-develop
frappe 12.0.20

Now we can checkout, at least:

erpnext@mine:~/frappe-bench$ cd apps/erpnext/
~/frappe-bench/apps/erpnext ~/frappe-bench

erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout version-12-hotfix
Branch 'version-12-hotfix' set up to track remote branch 'version-12-hotfix' from 'origin'.
Switched to a new branch 'version-12-hotfix'

erpnext@mine:~/frappe-bench/apps/erpnext$ cd ../..
~/frappe-bench

erpnext@mine:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20

But it still is not v12.2.3 … trying update:

erpnext@mine:~/frappe-bench$ bench update
INFO:bench.utils:updating bench
INFO:bench.utils:git pull
Already up to date.
INFO:bench.utils:./env/bin/pip install Pillow
Requirement already satisfied: Pillow in ./env/lib/python3.6/site-packages (6.2.1)
Backing up sites...
INFO:bench.app:pulling frappe
INFO:bench.utils:git pull  upstream version-12
From https://github.com/frappe/frappe
 * branch            version-12 -> FETCH_HEAD
Already up to date.
INFO:bench.utils:find . -name "*.pyc" -delete
INFO:bench.app:pulling erpnext
INFO:bench.utils:git pull  origin version-12-hotfix
From github.com:it-iridium-blue/erpnext
 * branch                  version-12-hotfix -> FETCH_HEAD
Already up to date.

BOOM

INFO:bench.utils:find . -name "*.pyc" -delete
Updating Python libraries...
INFO:bench.utils:./env/bin/pip install -q -U pip
INFO:bench.utils:/usr/local/bin/pip3 install --user -q -U -r /home/erpnext/.bench/requirements.txt
INFO:bench.app:installing frappe
INFO:bench.utils:./env/bin/pip install -q -U -e ./apps/frappe
INFO:bench.app:installing erpnext
INFO:bench.utils:./env/bin/pip install -q -U -e ./apps/erpnext
ERROR: Exception:
Traceback (most recent call last):
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_internal/req/req_install.py", line 441, in check_if_exists
    self.satisfied_by = pkg_resources.get_distribution(str(no_marker))
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 481, in get_distribution
    dist = get_provider(dist)
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 357, in get_provider
    return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pip._vendor.pkg_resources.ContextualVersionConflict: (python-dateutil 2.8.1 (/home/erpnext/frappe-bench/env/lib/python3.6/site-packages), Requirement.parse('python-dateutil<2.8.1,>=2.1; python_version >= "2.7"'), {'botocore'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_internal/cli/base_command.py", line 153, in _main
    status = self.run(options, args)
      :      : 
      :      : 
  File "/home/erpnext/frappe-bench/env/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pip._vendor.pkg_resources.ContextualVersionConflict: (python-dateutil 2.8.1 (/home/erpnext/frappe-bench/env/lib/python3.6/site-packages), Requirement.parse('python-dateutil<2.8.1,>=2.1; python_version >= "2.7"'), {'botocore'})
Traceback (most recent call last):
  File "/usr/local/bin/bench", line 11, in <module>
    load_entry_point('bench', 'console_scripts', 'bench')()
      :      : 
      :      : 
 File "/home/erpnext/.bench/bench/commands/update.py", line 84, in _update
    update_requirements(bench_path=bench_path)
  File "/home/erpnext/.bench/bench/utils.py", line 442, in update_requirements
    install_app(app, bench_path=bench_path)
  File "/home/erpnext/.bench/bench/app.py", line 171, in install_app
    exec_cmd("{pip} install {quiet} -U -e {app} {no_cache}".format(pip=pip_path, quiet=quiet_flag, app=app_path, no_cache=cache_flag))
  File "/home/erpnext/.bench/bench/utils.py", line 161, in exec_cmd
    raise CommandFailedError(cmd)
bench.utils.CommandFailedError: ./env/bin/pip install -q -U -e ./apps/erpnext

``

clarkej · December 14, 2019, 4:36pm

Thanks very much for that illustration Martin.

Re this:

erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout version-12-hotfix
Branch 'version-12-hotfix' set up to track remote branch 'version-12-hotfix' from 'origin'.
Switched to a new branch 'version-12-hotfix'

For the erpnext (and frappe) app repos, my understanding is the ''master" branch is version-12 rather than version-12-hotfix?

So version-12-hotfix receives say back port fixes that, once tested, are then merged into version-12 branch that runs in “production”?

MartinHBramwell · December 14, 2019, 4:57pm

So my mistake was switching to to the hotfix branch?

If I remember correctly I had the same Python bomb with version-12 as well.

I suspect I need further configuration adjustments before I can solve this, yet I don’t know what they are.

The thing that I don’t understand is:

erpnext@mine:~/frappe-bench/apps/erpnext$ git checkout version-12-hotfix
Branch 'version-12-hotfix' set up to track remote branch 'version-12-hotfix' from 'origin'.
Switched to a new branch 'version-12-hotfix'

erpnext@mine:~/frappe-bench/apps/erpnext$ cd ../..
~/frappe-bench

erpnext@mine:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20

Having just cloned the whole latest repo and switched to branch version-12, why has the bench version not changed (12.2.2 ==> 12.2.3)?
Does bench version take values come from ~/.bench, ~/frappe-bench or ~/frappe-bench/apps/erpnext?

When I switch to ~/.bench I find I have only part of the repo, as well…

erpnext@mine:~/.bench$  git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
erpnext@mine:~/.bench$ git checkout version-12
error: pathspec 'version-12' did not match any file(s) known to git.
erpnext@mine:~/.bench$

krnkris · December 14, 2019, 8:31pm

Could you help me to solve it please ?
Installed Apps was before bench update:
ERPNext: v12.1.8 (version-12)
Frappe Framework: v12.0.18 (version-12)

From this I updated bench

Same problem:

frappe@ubuntu:~/frappe-bench/apps/frappe$ git branch -a
* master
  version-11
  version-12
  remotes/upstream/HEAD -> upstream/develop
  remotes/upstream/adityahase-coverage-badge
  remotes/upstream/allow_quick_entry_fields
  remotes/upstream/auto-repeat-schedule
  remotes/upstream/clarkejj-patch-1
  remotes/upstream/clarkejj-patch-2
  remotes/upstream/codingCoffee-patch-1
  remotes/upstream/comment-delete-perm
  remotes/upstream/coverage-unexecuted-fix
  remotes/upstream/datatable-total-row
  remotes/upstream/dependabot/npm_and_yarn/mixin-deep-1.3.2
  remotes/upstream/dependabot/npm_and_yarn/tar-2.2.2
  remotes/upstream/dependabot/pip/markdown2-2.3.6
  remotes/upstream/dependabot/pip/pyyaml-5.1
  remotes/upstream/develop
  remotes/upstream/exception-handling-fix
  remotes/upstream/exclude_global_from_notification_emails
  remotes/upstream/expand-collapse-report-d
  remotes/upstream/file-email-attach
  remotes/upstream/fix-chat-less

and

frappe@ubuntu:~/frappe-bench/apps/erpnext$ git branch -a
  master
* version-12
  remotes/upstream/button-label-case
  remotes/upstream/close-quotation-fix
  remotes/upstream/develop
  remotes/upstream/master
  remotes/upstream/revert-19265-issue_fix
  remotes/upstream/revert-19417-v12-pre-release
  remotes/upstream/revert-19432-showing_untitled_name_in_item_tax_template
  remotes/upstream/scmmishra-patch-1
  remotes/upstream/v10.x.x
  remotes/upstream/v11-pre-release
  remotes/upstream/v12-pre-release
  remotes/upstream/v4.x.x
  remotes/upstream/v5.x.x
  remotes/upstream/v6.x.x
  remotes/upstream/v7.0.x
  remotes/upstream/v7.x.x
  remotes/upstream/v8.x.x
  remotes/upstream/v9.x.x
  remotes/upstream/version-11
  remotes/upstream/version-11-hotfix
  remotes/upstream/version-12
:

frappe@ubuntu:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 11.1.44

Akram_Mutaher · December 14, 2019, 9:20pm

Edit the file:

apps > erpnext> .git > config :

[remote "upstream"]
    url = https://github.com/frappe/erpnext
    fetch = +refs/heads/*:refs/remotes/upstream/*

Then do:
bench switch-to-branch version-12 frappe erpnext

bench update --patch

MartinHBramwell · December 14, 2019, 9:47pm

PERFECT ! !

almost

Followed your steps exactly. No errors. Great relief! But …

erpnext@mine:~/frappe-bench$ bench version
erpnext 12.2.2
frappe 12.0.20
erpnext@mine:~/frappe-bench$

Still at v12.2.2 ! !

Akram_Mutaher · December 14, 2019, 9:54pm

Yes, that is main issue in this topic not solved yet