Report Broken/Outdated Resource Links Here & How to Flag

JoEz · October 27, 2016, 7:40am

@moderators Missing images on:

https://frappe.github.io/frappe/user/en/guides/reports-and-printing/how-to-make-query-report.html

https://frappe.github.io/frappe/user/en/guides/reports-and-printing/how-to-make-script-reports.html

kickapoo · October 27, 2016, 7:47pm

@moderators
broken source in https://frappe.github.io/frappe/current/api/email/frappe.email

https://github.com/frappe/frappe/blob/develop/frappe/email.py → 404

gvyshnya · October 31, 2016, 1:17pm

@moderators, @Eric_Delisle:

Below is the full report on broken links on pages of English version of Frappe Developer guides (https://frappe.github.io/frappe/user/en/guides/) . The report points to the missing images/fonts/css libs as well as a few abandoned pages on frappe and ERP Next sites.

for your convenience, I also dumped the list of URLs responding with error 404 there:

I hope it is helpful.

George

gvyshnya · October 31, 2016, 1:20pm

More generic report on missing links within the children of http://frappe.github.io/frappe/user/en/

Status URL Source link text

gvyshnya · October 31, 2016, 1:26pm

Below is the same sort of broken links report on ERP Next document storage (http://frappe.github.io/erpnext/):

rmehta · November 1, 2016, 3:31pm

Thanks! @gvyshnya this is on my list now :). Can you share the script you used to build this list?

andrilio · November 2, 2016, 12:18pm

Batchwise inventory: Not Found & Frappe Cloud

gvyshnya · November 3, 2016, 1:59pm

@rmehta: i used one of the popular online tools for broken link checking - http://www.deadlinkchecker.com/

gvyshnya · November 3, 2016, 2:06pm

A few more broken link reports from the top-level site of http://erpnext.com/

gvyshnya · November 7, 2016, 12:48pm

One more detection is related to the missing subdomain - http://manual.erpnext.com

It now redirects to the sign-up form (https://erpnext.com/signup?plan=Free&domain=manual.erpnext.com), whatever URL within this subdomain is specified. In turn, some earlier forum posts as of 2015 referred pages on manual.erpnext.com (see Customize forms and Link type woes. Can anybody lend a quick minute to help? - #2 by saurabh6790, for instance - it refers to Frappe Cloud ).

It would be better if manual.erpnext.com redirects to the appropriate location of developer manuals as of the end of 2016.

gvyshnya · November 7, 2016, 12:56pm

Below is the list of problems/issues with links on http://community.erpnext.com

gvyshnya · November 7, 2016, 3:33pm

One more portion of broken links - this time, a sort of recursion is implied as it posts broken links for this discussion board (http://discuss.frappe.io):

rmehta · November 21, 2016, 7:57am

Fixed most of the broken links!

Eric_Delisle · November 21, 2016, 10:36pm

You rock, Rushabh !

gvyshnya · November 22, 2016, 10:47am

Great, @rmehta ! Well done!

gvyshnya · November 24, 2016, 2:18pm

@rmehta: there is a collateral issue related to broken links. The matter is some of the earlier-generation page urls have been cached by search engines like Google. They keep appearing in search query results for real users, and such users get 404 error experience when attempted to navigate to such links (since there is nowhere to land with those urls now).

The medicine for those issues would be configuring redirect / url rewrite rules on the frappe host.

For instance, I noticed such a ghost link cached by Google per https://frappe.github.io/frappe/user/tutorial/form-client-scripting

I believe the actual page for this URL moved to https://frappe.github.io/frappe/user/en/tutorial/form-client-scripting as of this moment. Therefore a kind of url rewrite like,

https://frappe.github.io/frappe/user/tutorial/[whatever] → https://frappe.github.io/frappe/user/en/tutorial/[the_same-whatever]

could help to get rid of this tiny piece of inconvenience.

Will you be able to run the additional pass on identifying and implementing such redirect rules/ url rewrite handles?

Thank you.

gvyshnya · December 1, 2016, 12:27pm

@rmehta: one more orphan link from the past generations of the sites that is cached in Google as well as available in the earlier forum posts is Not Found (see it linked from Zapier integration with ERPNext - #5 by rmehta, for instance).

It would be nice to configure the redirect of such a url to the most recent location of the community job resource at https://community.erpnext.com/jobs

gvyshnya · December 7, 2016, 7:17pm

@rmehta: you would not be surprised of me reporting one more branch of ghost links from past incarnations of ERP Next / Frappe sites

This time I refer to the former knowledge base Not Found and all of its child pages … One of such links (https://erpnext.com/kb/customize/user-restriction) is posted in the forum (at User Permissions and Roles - #6 by Dale_Scott)

I am not sure where the right place to point the redirect is. You will probably be at a better position to decide on it.

rmehta · December 8, 2016, 10:24am

@gvyshnya you are now a moderator, so feel free to fix links! (sorry should have done that earlier)

Me neither, I usually Google for the right answer,

gvyshnya · December 8, 2016, 11:41am

@rmehta: thank you for the credit. I will be happy to watch the ghost links in the forum posts. At the same time, editing ghost links would not be enough as we won’t be able to catch everyting in a finite time. This will also not protect from 404 experience on navigating the ghost links cached by Google, Bing etc. True redirect rules will be really helpful for both erpnext.com and frappe.io domains ( I am aware it will be hard to control redirects for the frappe and erpnext auxiliary sites in github.com).

I will therefore become a volunteer to maintain nginx redirect rules for your sites I can do it in one of the following ways

Maintain separate forum topics for such rules (in Community area) - the original post of such threads will be constantly updated for your admins to grab the updated rules to your nginx instances
Add the respective code fragments to both erpnext and frappe repos on github - in this case, I will be submitting updates via PRs there

Please let me know what your thoughts on that are.

P.S. In terms of the format of the redirect rules, I will maintain it via map as follows


map $uri $redirect_uri {

~^/ghost_page/?$    http://erpnext.com/_new_page_uri_;

# … multiple entries will go below

}
location / {

try_files $uri $uri/ @redirect-map;

}

location @redirect-map { if ($redirect_uri) { # redirect if the variable is defined return 301 $redirect_uri; } }