Rest API give general ledger api permission to Guest

shahid · August 20, 2020, 9:39pm

Hi,

I want to give general ledger permission to guest user using api.
i tried /api/method/frappe.desk.query_report.run but it says not permitted,

then i duplicate general ledger and added @frappe.whitelist(allow_guest=True) before execute function but it still says not permitted.

khushal_t · August 21, 2020, 4:52am

can you show full path and work you have done ? then only someone can help

shahid · August 21, 2020, 11:11am

Path :

/api/method/erpnext.accounts.report.account_activity.account_activity.execute?api=1&filters={"company": "Test", "report_type": "All",
	"from_date": "2020-07-20",
	"to_date": "2020-08-20",
	"group_by": "Group by Voucher Consolidated",
	"include_default_book_entries": 1}

Change in Code:

youssef · August 21, 2020, 11:43am

Try use ‘frappe.set_user(“Administrator”)’ or any user has proper privilege.

shahid · August 21, 2020, 12:04pm

Still says not permitted.

youssef · August 21, 2020, 12:16pm

Should put it into the def

youssef · August 21, 2020, 12:39pm

github.com

frappe/erpnext/blob/39a7516252a71ed57240de18345e5f9a5a6bdc2f/erpnext/accounts/report/accounts_receivable/test_accounts_receivable.py#L57


      
          		make_credit_note(name)
          		report = execute(filters)
          
          
		expected_data_after_credit_note = [100, 0, 0, 40, -40]
          
          
		row = report[1][0]
          		self.assertEqual(expected_data_after_credit_note,
          			[row.invoice_grand_total, row.invoiced, row.paid, row.credit_note, row.outstanding])
          
          
def make_sales_invoice():
          	frappe.set_user("Administrator")
          
          
	si = create_sales_invoice(company="_Test Company 2",
          			customer = '_Test Customer 2',
          			currency = 'EUR',
          			warehouse = 'Finished Goods - _TC2',
          			debit_to = 'Debtors - _TC2',
          			income_account = 'Sales - _TC2',
          			expense_account = 'Cost of Goods Sold - _TC2',
          			cost_center = 'Main - _TC2',
          			do_not_save=1)

shahid · August 21, 2020, 12:55pm

Still same issue.

youssef · August 21, 2020, 12:56pm

Can you share the code again please

shahid · August 21, 2020, 12:57pm

@frappe.whitelist(allow_guest=True)
def execute(filters=None, api=0):
	frappe.set_user("Administrator")
	if not filters:
		return [], []
	if api:
		filters = json.loads(filters)

youssef · August 21, 2020, 12:58pm

Have you restart bench ?

shahid · August 21, 2020, 1:01pm

Yes i did,
also tried other users that have required permissions but still same.

shahid · August 21, 2020, 1:14pm

@youssef thanks for your time and help. it starts working after clearing caches of my browser.