Role Permission - only see Events created by self or assigned

Iulian_Olaru · September 6, 2019, 10:40am

So I have been working on this in different ways for hours now … definitely I haven’t mastered any user permissions understanding here haha

What are the optimum settings for a newly created user role to only see events created by himself or assigned to himself?

Mohammed_Redha · September 6, 2019, 11:04am

Iulian_Olaru · September 6, 2019, 11:07am

Yep, I enabled Only if Creator, and still, the user is able to see all Events created by all users. Isn’t that strange ?

Current role permission settings:

Current view of the calendar:

The one user under the newly created Role “Agent” should only be able to see 1 event assigned to him. The user has no events created yet.

Iulian_Olaru · September 10, 2019, 5:10am

Does anyone know how to accomplish this ? I’ve been moving permissions around in all possible ways… it seems impossible ?

Example, level 0 role permission for his Role and I disabled Read permission - the user can still see all Events added by all users. That is not supposed to be possible, right ?

Iulian_Olaru · September 10, 2019, 8:10am

Here is a screenshot of the latest settings for the new Role.

The user under the Role “Agent” is still able to see all events created by all users.

Is this a normal behaviour for the settings I made ?

Iulian_Olaru · September 11, 2019, 5:24am

With the risk of making some people upset - it seems I have discovered that the Role Permission do not actually do what they should be doing.

Looking through everything, it seems that the “Only if Creator” option is a null option without any effects. And as it “Only If Creator” on any doctype is pointless.

This of course brings up an issue regarding role and user permissions because you can’t hide anything from any user. Basically you either hide everything or you show everything …

Question comes now, am I right or wrong ? and if I’m right, how and when can we achieve the “Only If Creator” to actually be functional.

Iulian_Olaru · September 11, 2019, 5:40am

Link to the GitHub issue: v12 Role Permissions - "Only If Creator" does not work · Issue #18996 · frappe/erpnext · GitHub

Iulian_Olaru · September 15, 2019, 11:00am

This situation is still active with no information … “Only If Creator” does not work and a reply from someone who knows what’s happening would be very much helpful.

surajshetty · September 15, 2019, 12:32pm

@Iulian_Olaru
Events doctype has custom permission checks and it does not obey role permissions changes.

Note: Public events are visible to all users and private events are visible only to the creator of the event.

Check the following code for better understanding…

github.com

frappe/frappe/blob/develop/frappe/desk/doctype/event/event.py#L109


      
          		self.communication = communication.name
          
          
	def update_communication(self, participant, communication):
          		communication.communication_medium = "Event"
          		communication.subject = self.subject
          		communication.content = self.description if self.description else self.subject
          		communication.communication_date = self.starts_on
          		communication.sender = self.owner
          		communication.sender_full_name = frappe.utils.get_fullname(self.owner)
          		communication.reference_doctype = self.doctype
          		communication.reference_name = self.name
          		communication.communication_medium = (
          			communication_mapping.get(self.event_category) if self.event_category else ""
          		)
          		communication.status = "Linked"
          		communication.add_link(participant.reference_doctype, participant.reference_docname)
          		communication.save(ignore_permissions=True)
          
          
	def add_participant(self, doctype, docname):
          		"""Add a single participant to event participants

Best,
Suraj

Iulian_Olaru · September 16, 2019, 2:17am

Thank you for the explanation @surajshetty

In this case, help me please to understand at a user friendly level, can we make Events to follow the role permissions changes ? are these changes possible ?

Or, at least, how can we hide events from specific user roles ? it’s not possible that everyone sees everything. This is a bit too rough and inflexible at least for our companies using erpnext.

We use the events as our reservation system. Hence we create hundreds of events on a monthly basis.

Now we want to create a special user role for our Agents who will be able to add new reservations and view their own reservations but of course, they cannot see the events created by other Agents.

Also, can System Administrators or specific user roles see private events created by other users ?