Salary Component Account Root Types

I noticed this commit: fix: Salary component account filter by pateljannat · Pull Request #26604 · frappe/erpnext · GitHub
However, this goes against how the Demo is setup. If you look at Retail demo the salary component “Basic” is linked to “Salary” account and this account’s root type is an expense. I’m pretty sure this commit is supposed to be opposite. I’m not an accountant so I’m not 100% sure.

For salary component “Earning” type, expenses accounts are also needed as they are earned by employee. But to employer, they are expenses. Do not understand the reasons to restrict “earning” salary component to “Liability” type.

It has been reverted.