Salary Slip: Statistical Component

bghayad · September 7, 2017, 8:53pm

Hello;
The statistical component is important for me to appear in the database because I need it to be used in generating reports. But I do not need it to appear in the salary slip to avoid confusing.
When I was selecting the component to be statistical, I was think that it will be available in the database to be used whenever it is needed. But I discover that it is not appearing in the tabSalary Detail table.
How to resolve this?
Regards
Bilal

magic-overflow · September 8, 2017, 2:04am

It’s not configurable, you have to change the code in salary_slip.py. Only Salary component amount which not zero and not statistical will insert into tabSalary Detail table.

github.com

frappe/erpnext/blob/9bc2b66e14f2952ab834742481ceef0ed396c93e/erpnext/hr/doctype/salary_slip/salary_slip.py#L58


      
          
          
	def calculate_component_amounts(self):
          		if not getattr(self, '_salary_structure_doc', None):
          			self._salary_structure_doc = frappe.get_doc('Salary Structure', self.salary_structure)
          
          
		data = self.get_data_for_eval()
          
          
		for key in ('earnings', 'deductions'):
          			for struct_row in self._salary_structure_doc.get(key):
          				amount = self.eval_condition_and_formula(struct_row, data)
          				if amount and struct_row.statistical_component == 0:
          					self.update_component_row(struct_row, amount, key)
          
          
	def update_component_row(self, struct_row, amount, key):
          		component_row = None
          		for d in self.get(key):
          			if d.salary_component == struct_row.salary_component:
          				component_row = d
          
          
		if not component_row:
          			self.append(key, {

rajeeb · June 17, 2019, 8:59am

@magic-overflow I tried of changing this code you have mentioned. But it is not working for Zero Value amount but for Statistical Component. I want this to be applied for Amounts too.

Any solutions ??

Khadija · June 17, 2019, 9:56am

what exactly change you made in code?

rajeeb · June 17, 2019, 10:19am

@Khadija I removed ‘amount’ from that line like this :

    if struct_row.statistical_component == 0:
            self.update_component_row(struct_row, amount, key)

Khadija · June 17, 2019, 10:25am

that’s weird it should have worked

jackbulb · December 18, 2020, 4:27am

Hi, currently facing the same issue.

Removed amount on this line

if struct_row.statistical_component == 0:
self.update_component_row(struct_row, amount, key)

Was wondering if anyone found a fix for this ?