SSO auth with Discord OAuth

ERPNext
1

Good afternoon.

I’m trying to set up authorization using Discord. Right now I have something like these settings:

image
image955×932 35.5 KB

But I ran into some problems:

  1. “scope”: “identify+email” becomes scope=identify%2Bemail, but Discord Expects a plus sign there and crashes with the error “Incorrect scope”
  2. redirect_url becomes https%3A%2F%2Ferp%2Cphoenix-arma.ru%2Fapi%2Fmethod%2Ffrappe.integrations.oauth2_logins.login_via_discord, but for discord this is an uncorrected url, it expects https%3A%2F%2Ferp.phoenix-arma.ru%2Fapi%2Fmethod%2Ffrappe.integrations.oauth2_logins.login_via_discord

Simply put, there should be a dot for the subdomain, but it is escaped.

Is there any way to solve these problems?

2

I fix error with scope, I use space without plus.
But dot in subdomain also encoding.

How I can fix this?

3

I fix redirect_url.
I add full redirect path: https://erp.domain.ru/api/method/frappe.integrations.oauth2_logins.custom/discord

But, i have new error: incorrect_client

4

I defeated Discord OAuth.
But now I get the error:
frappe.exceptions.MandatoryError: [User, example@email.com]: first_name

5

You need additional scope. Generally “openid”. It will then return additional claims required to create user in frappe.

1 Like
6

No, this is the first thing I tried.

In principle, Discord does not provide the fields that frappe (first_name) expects, instead username could be written there.

Is there any way to do this using a server script or some other way without changing the source code?

7

Instead of pointing the redirect to general whitelisted function, use your own custom endpoint with custom mapping.

E.g. microsoft_integration/microsoft_integration/callback.py at f46fab88813220a5276af5628208f0f16dc9b162 · castlecraft/microsoft_integration · GitHub

1 Like