Status not updating in project module (On hold)

Mubasher · April 20, 2025, 9:56am

i have added one more option of on hold in status for project but when i select and save it shows open

black_mamba · April 20, 2025, 4:42pm

Can you please elaborate how did you add this field? Was it in DocType itself or was it via Custoimze option ?

Would appreciate if you can also add version information for more context.

avc · April 20, 2025, 5:21pm

Hi @Mubasher:

Most of ERPNext doctypes includes some logic …

Check the field "% Complete method" … for your project. Is “Manual”, “Task progress”, “Task completion”?

Depending of this value, on form validating, this method is called. Under some circumstances, status will be switched to “Open”.

github.com

frappe/erpnext/blob/32d5597d23f628256a922f8695c7dacf6f3b2e75/erpnext/projects/doctype/project/project.py#L213


      
          		self.db_update()
          
          	def after_insert(self):
          		self.copy_from_template()  # nosemgrep
          		if self.sales_order:
          			frappe.db.set_value("Sales Order", self.sales_order, "project", self.name)
          
          	def on_trash(self):
          		frappe.db.set_value("Sales Order", {"project": self.name}, "project", "")
          
          	def update_percent_complete(self):
          		if self.status == "Completed":
          			if (
          				len(frappe.get_all("Task", dict(project=self.name))) == 0
          			):  # A project without tasks should be able to complete
          				self.percent_complete_method = "Manual"
          				self.percent_complete = 100
          
          		if self.percent_complete_method == "Manual":
          			if self.status == "Completed":
          				self.percent_complete = 100

Hope this helps.

Mubasher · April 21, 2025, 5:38am

Yeah i got it i added some extra fields so it will not work with the logic as it is related with the completion method so now i m using the manual method thank you for your time