Stock Balance Report - issue with UOMs

omkar_ghatpande · January 27, 2015, 10:30am

In the Stock Balance Report, for some of the items which already have a Stock UOM set as drums, the Stock UOM in report is showing up as Nos.

Anyone has observed similar behavior? Any ideas as how to rectify?

Thanks for your help!

rmehta · January 28, 2015, 5:13am

Can you raise this at GitHub Issues?

kolate_sambhaji · February 20, 2015, 5:29am

Hi Team,

I solve this issue.
In Stock Balance Report,
Currently we are fetching stock_uom from Stock Ledger Entry.
If we fetch stock_uom from Item then we will get correct result.

While
solving this, I found one strange behavior, Delivery Notes makes Stock
Ledger Entry with wrong stock_uom. We have also solve this bug. (thank
@BhupeshGupta and gitter.im)

If you run the below query, you can trace result for delivery note.

select item_code, warehouse, posting_date, actual_qty, 
valuation_rate,stock_uom, company, voucher_type, 
qty_after_transaction,stock_value_difference from `tabStock Ledger Entry`;

Can you please check this issue? or Can I send pull request for this?

Thanks,
Sambhaji

nabinhait · February 20, 2015, 6:51am

@kolate_sambhaji

Fixing in above query is temporary solution. We have to find out the root cause, why stock_uom is going wrong in case of Delivery Note? I can’t replicate it locally. But it is a serious issue, if you found out the root cause, please send the PR. Otherwise, we can check into the issue via screen sharing.

kolate_sambhaji · February 20, 2015, 7:09am

github.com

frappe/erpnext/blob/develop/erpnext/controllers/selling_controller.py#L393


      
          		return so_qty, so_warehouse
          
          
	def check_sales_order_on_hold_or_close(self, ref_fieldname):
          		for d in self.get("items"):
          			if d.get(ref_fieldname):
          				status = frappe.db.get_value("Sales Order", d.get(ref_fieldname), "status")
          				if status in ("Closed", "On Hold"):
          					frappe.throw(_("Sales Order {0} is {1}").format(d.get(ref_fieldname), status))
          
          
	def update_reserved_qty(self):
          		so_map = {}
          		for d in self.get("items"):
          			if d.so_detail:
          				if self.doctype == "Delivery Note" and d.against_sales_order:
          					so_map.setdefault(d.against_sales_order, []).append(d.so_detail)
          				elif self.doctype == "Sales Invoice" and d.sales_order and self.update_stock:
          					so_map.setdefault(d.sales_order, []).append(d.so_detail)
          
          
		for so, so_item_rows in so_map.items():
          			if so and so_item_rows:
          				sales_order = frappe.get_doc("Sales Order", so)

github.com

frappe/erpnext/blob/develop/erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.py#L71


      
          	def calculate_batch_qty(self):
          		if self.batch_no:
          			batch_qty = (
          				frappe.db.get_value(
          					"Stock Ledger Entry",
          					{"docstatus": 1, "batch_no": self.batch_no, "is_cancelled": 0},
          					"sum(actual_qty)",
          				)
          				or 0
          			)
          			frappe.db.set_value("Batch", self.batch_no, "batch_qty", batch_qty)
          
          
	def validate_mandatory(self):
          		mandatory = ["warehouse", "posting_date", "voucher_type", "voucher_no", "company"]
          		for k in mandatory:
          			if not self.get(k):
          				frappe.throw(_("{0} is required").format(self.meta.get_label(k)))
          
          
		if self.voucher_type != "Stock Reconciliation" and not self.actual_qty:
          			frappe.throw(_("Actual Qty is mandatory"))

delivery note’s item dict contains uom,
If we change uom to stock_uom, our problem solves
I will send pull request for better understanding.

kolate_sambhaji · February 20, 2015, 7:50am

I have send pull request. #2803
Please review it.
for replicating issue we can share screen. I can show this issue in my local machine.

nabinhait · February 20, 2015, 8:59am

Thanks, merged the PR
Also pushed a patch to fix stock_uom in existing sle update stock uo in sle for DN · frappe/erpnext@ad3fd51 · GitHub

kolate_sambhaji · February 20, 2015, 9:14am

Thanks for the patch,
This will fix my existing sle

one more question,
We have custom requirement similar to this issue.
https://github.com/frappe/erpnext/issues/1391
Per unit Cost in Stock Balance report .

Currently, I am fetching Last Purchase Rate from Item.
I need suggestion, which is best way/value of showing Unit Rate For Item.