Terms not fetching in purchase order

Mubasher · August 25, 2024, 9:52am

after i create purchase order from sales order it is not fetching terms data in terms field

is is fetching all the other fields that are fetched form the terms but not showing terms field

avc · August 25, 2024, 11:59am

I don’t know if it make sense … From my POV terms and conditions should be different (in most cases) for sales and purchase paths.

Anyway is doable if you need it with client/server scripting.

Mubasher · August 25, 2024, 12:07pm

haha i completely understand but it is client requirment what can we do
i hope you have heard the quote that “customer is always right!” so…

Mubasher · August 25, 2024, 12:14pm

ACTUALLY WE ARE CREATING 4 DOCUMENTS AND FOR ALL DOCUMENTS TERMS AND CONDITIONS ARE SAME AS IT IS FOR THE SAME COMPANY I ADDED THE OPTION FOR SELECTING CUSTOM TERMS BUT IT IS THE REQUIREMENT THAT IT SHOULD FETCH FROM PREVIOUS DOCUMENT so we need.

Mubasher · August 25, 2024, 12:16pm

it is fetching all data properly i think it can be a bug or something becuase when i create quotaion from opportunity it is fetching terms with it’s fields. but when i create sales order from quotation it is not fetching terms. but if i create sales invoice or purchase prder from sales order it is fetching the terms again… what can i say…

avc · August 25, 2024, 12:26pm

Hi @Mubasher:

Yeah, i heard it through the grapevine

Different approaches (complexity order ascending):

Server script for purchase order, at validating or saving. Here you should check if all the item rows come from the same sales order. If so, get the SO terms and apply …
Create new client function and server method (with client/server script) for funcionality. Add a new button like “Create purchase order with terms” and call method created on server script.
Override server method …

github.com

frappe/erpnext/blob/6721ae76dea1bebd328192a9c14325d904c8986b/erpnext/selling/doctype/sales_order/sales_order.py#L1374


      
          		)
          
          		doc.insert()
          		frappe.db.commit()
          		purchase_orders.append(doc)
          
          	return purchase_orders
          
          
          @frappe.whitelist()
          def make_purchase_order(source_name, selected_items=None, target_doc=None):
          	if not selected_items:
          		return
          
          	if isinstance(selected_items, str):
          		selected_items = json.loads(selected_items)
          
          	items_to_map = [
          		item.get("item_code") for item in selected_items if item.get("item_code") and item.get("item_code")
          	]
          	items_to_map = list(set(items_to_map))

Hope this helps.

NCP · August 26, 2024, 4:52am

Hi @Mubasher,

We recently removed it because, in some cases, when suppliers have default payment terms or terms and conditions, they weren’t being applied correctly. We tested this with multiple client scenarios, and they noted that the terms from the sales order should not be set in the purchase order. However, if you’d like, you can check my Pull Request, remove the added changes, and this should solve your problem.