Time datatype default value

Frappe Framework App Development
1

Hi all ,
i`m working on Time attendance App .
and i have fields like attend_time and leave_time with datatype (Time)
but when i try to make new doc and insert in attendance doctype with one them the other take time to now and does not take null value
even if i try to set the value to empty from the attendance doctype does not take empty value
please help :frowning:

def add_attendance(employee, status, date, attend_time=None, leave_time=None, late_minutes=0.0, attend_notes=None, leave_type=None):
		attendance = frappe.new_doc("Attendance")
		attendance.employee = employee['employee']
		attendance.employee_name = employee['employee_name']
		attendance.attendance_date = date
		attendance.attend_time = attend_time
		attendance.leave_time = leave_time
		attendance.delay_minutes = late_minutes
		attendance.notes = attend_notes
		attendance.status = status
		attendance.company = frappe.db.get_value("Employee", employee['employee'], "Company")

		if status == "On Leave" and leave_type:
			attendance.leave_type = leave_type
		attendance.submit()
2

it cannot be empty, instead you can set 0 value to it.
frm.set_value(“attend_time”, “0”);

3

i put

elif df.fieldtype == "Time" and d[fieldname] == "":
	d[fieldname] = None

in function get_valid_dict(self, sanitize=True, convert_dates_to_str=False) in file base_document.py
and it works
thanks

4

Does this work in later versions of frappe? Is this fix good enough to raise a PR?

5

do you find a solution for this in version 15?

6

Try This…


frappe.ui.form.on('test', {
	 before_save: function (frm) {
		if(frm.doc.my_time = ""){
		    frm.set_value("my_time", "");
		}
		if(frm.doc.my_time = ""){
		    frm.set_value("my_time", "");
		}
	}
})