Unable to Create New Fixed Asset in both v12 and v13

adityaduggal · June 9, 2022, 2:35am

Hi While creating a new asset we are getting the following error:

Traceback (most recent call last):
  File "apps/frappe/frappe/desk/form/save.py", line 25, in savedocs
    doc.save()
  File "apps/frappe/frappe/model/document.py", line 310, in save
    return self._save(*args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 332, in _save
    return self.insert()
  File "apps/frappe/frappe/model/document.py", line 256, in insert
    self.set_new_name(set_name=set_name, set_child_names=set_child_names)
  File "apps/frappe/frappe/model/document.py", line 464, in set_new_name
    set_new_name(self)
  File "apps/frappe/frappe/model/naming.py", line 46, in set_new_name
    doc.run_method("autoname")
  File "apps/frappe/frappe/model/document.py", line 941, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1260, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1242, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 938, in fn
    return method_object(*args, **kwargs)
TypeError: 'int' object is not callable
request.js:430:14
Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 69, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 38, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 76, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1448, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/desk/form/save.py", line 25, in savedocs
    doc.save()
  File "apps/frappe/frappe/model/document.py", line 310, in save
    return self._save(*args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 332, in _save
    return self.insert()
  File "apps/frappe/frappe/model/document.py", line 256, in insert
    self.set_new_name(set_name=set_name, set_child_names=set_child_names)
  File "apps/frappe/frappe/model/document.py", line 464, in set_new_name
    set_new_name(self)
  File "apps/frappe/frappe/model/naming.py", line 46, in set_new_name
    doc.run_method("autoname")
  File "apps/frappe/frappe/model/document.py", line 941, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1260, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1242, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 938, in fn
    return method_object(*args, **kwargs)
TypeError: 'int' object is not callable
request.js:430:14

Pawan · June 9, 2022, 3:03am

Did you try to run, bench build from your frappe-bench directory?

adityaduggal · June 20, 2022, 9:52pm

On my test server I have tried bench --site site_name build but even after that I am getting the same error. This error is coming in both test and production server since last 2~3 months and we are unable to create any new assets.

Seems like a weird error, unable to resolve

adityaduggal · June 20, 2022, 11:52pm

I think I found a BUG:

github.com

frappe/frappe/blob/11932508c661dac90c2c51140f2af9c34940e9f8/frappe/model/document.py#L802


      
          		return ret
          
          
	def run_method(self, method, *args, **kwargs):
          		"""run standard triggers, plus those in hooks"""
          
          
		def fn(self, *args, **kwargs):
          			method_object = getattr(self, method, None)
          
          
			# Cannot have a field with same name as method
          			# If method found in __dict__, expect it to be callable
          			if method in self.__dict__ or callable(method_object):
          				return method_object(*args, **kwargs)
          
          
		fn.__name__ = str(method)
          		out = Document.hook(fn)(self, *args, **kwargs)
          
          
		self.run_notifications(method)
          		run_webhooks(self, method)
          		run_server_script_for_doc_event(self, method)
          
          
		return out

Now in Asset there is a field called “depreciation_method” I think because of which this error is coming and it was introduced in Mar-2022 only.

Refer the json for Asset as well:

github.com

frappe/erpnext/blob/version-12/erpnext/assets/doctype/asset/asset.json#L272


      
           "fieldtype": "Table",
           "label": "Finance Books",
           "options": "Asset Finance Book"
          },
          {
           "fieldname": "section_break_33",
           "fieldtype": "Section Break",
           "hidden": 1
          },
          {
           "fieldname": "depreciation_method",
           "fieldtype": "Select",
           "label": "Depreciation Method",
           "options": "\nStraight Line\nDouble Declining Balance\nManual"
          },
          {
           "fieldname": "value_after_depreciation",
           "fieldtype": "Currency",
           "hidden": 1,
           "label": "Value After Depreciation",
           "options": "Company:company:default_currency",

And same goes for version-13 as well.

adityaduggal · June 21, 2022, 12:11am

Turns out I had a custom field named autoname in the document ASSET which was creating this error removing that field or renaming has resolved this issue.