Unable to save DocType - ValueError: could not convert string to float: ''

ERPNext
1

Hi, I am running V13 and have a new DocType which I made some changes in the DB directly and then made changes from Customization for a field set from data to currency. There are around 20 fields in the form which are of different types. The problem is when I save the form/Customizations I get the error

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
    response = frappe.api.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1172, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 234, in run_doc_method
    response = doc.run_method(method)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 861, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1153, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1136, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 855, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/custom/doctype/customize_form/customize_form.py", line 151, in save_customization
    frappe.db.updatedb(self.doc_type)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/mariadb/database.py", line 282, in updatedb
    db_table.sync()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/schema.py", line 40, in sync
    self.alter()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/mariadb/schema.py", line 41, in alter
    col.build_for_alter_table(self.current_columns.get(col.fieldname.lower()))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/schema.py", line 222, in build_for_alter_table
    if (self.default_changed(current_def)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/schema.py", line 239, in default_changed
    return self.default_changed_for_decimal(current_def)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/database/schema.py", line 279, in default_changed_for_decimal
    return float(current_def['default'])!=float(self.default)
ValueError: could not convert string to float: ''

and I can’t seem to be able to figure out which field it is frappe is trying to modify or sync from the DB because this line

ValueError: could not convert string to float: ''

is empty. I tried truncate and drop the table and recreated from bench migrate but even then when I try to save the customization or the DocType I get this error. Any pointers on how to get this resolved or what’s causing this issue?

Thanks.

2

Hi, were you able to solve this issue? I am facing a similar issue.

3

Hi, I have a similar problem too when trying to customise a doctype, I get:

ValueError: could not convert string to float: ‘NULL’

Any ideas?

Thanks.

4

This error occurred while migrating the your-DocType DocType. The root cause was identified as a mismatch between the database schema’s default values and the DocType definition.

which means there is a column that is int or decimal type, but it’s default value is ‘NULL’

the solution:
1- open a MariaDB/MySQL shell connected to the specific site (your-site) database.

bench --site your-site mariabd

2- Use the following SQL query to inspect the column definitions:

SHOW COLUMNS FROM `tabYour DocType`;
  • Look for columns where the Default value is 'NULL' but should be numeric,
    which means there is column its type is numeric (int, decimal…) but the default value is ‘NULL’

3- Update the Database Schema :
If any column has 'NULL' as its default value but should have a numeric default, update the schema using an ALTER TABLE statement. For example:

ALTER TABLE `tabYour DocType` MODIFY COLUMN `column1` INT DEFAULT 0;
  • Repeat this for any other columns where the DocType specifies a numeric default but the database schema has NULL.

4- Clear Cache and Retry Migration :
After updating the schema, clear the Frappe cache to ensure the changes are recognized

bench --site your-site clear-cache

bench --site your-site migrate
1 Like