V11.1.14 #Error Item Variant based on Manufacturer

1

Hello,

I found an issue having v11.1.14. After I created a template based on Manufacturer, I can’t create a variant because it asks for “Please specify at least one attribute in the Attributes table”

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 61, in application
    response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 21, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 56, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1026, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/item_variant.py", line 35, in get_variant
    frappe.throw(_("Please specify at least one attribute in the Attributes table"))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 353, in throw
    msgprint(msg, raise_exception=exc, title=title, indicator='red')
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 339, in msgprint
    _raise_exception()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 312, in _raise_exception
    raise raise_exception(msg)
frappe.exceptions.ValidationError: Please specify at least one attribute in the Attributes table

Creating variants upon a template only works with attributes.

2

I’ve post multiple issues regarding this problem from v9, 10 and 11 no fix
so far the problem is here erpnext/item.js at af309473f8c81a3a705b4cc869dd202d18266aaa · frappe/erpnext · GitHub

// code
show_modal_for_manufacturers: function(frm) {
var dialog = new frappe.ui.Dialog({
fields: [
{fieldtype:‘Link’, options:‘Manufacturer’,
reqd:1, label:‘Manufacturer’},
{fieldtype:‘Data’, label:‘Manufacturer Part Number’,
fieldname: ‘manufacturer_part_no’},
]
});
where in the Dialog, here the fields are missing the fieldname: ‘manufacturer’ like manufacturer_part_no has.
final code should be

var dialog = new frappe.ui.Dialog({
    			fields: [
    				{fieldtype:'Link', options:'Manufacturer',
    					fieldname: 'manufacturer', reqd:1, label:'Manufacturer'},
    				{fieldtype:'Data', label:'Manufacturer Part Number',
    					fieldname: 'manufacturer_part_no'},
    			]
    		});

add fieldname: ‘manufacturer’, and bench build and should be fixed
I hope someone can push this fix asap