v5 - Unable to Remove Custom Field

bohlian · April 21, 2015, 9:56am

Am trying to remove a custom field which was created in the Customer form and am unable to do so. Error message is “Cannot delete standard field. You can hide it if you want”.

Just some extra details:

Created the field on row 20
Label: Flat Rate ID Number

Under customize_form.js i noticed that it tests for “if(!(row.is_custom_field || row.__islocal))” but I have been unable to trace where it pulls these values from. Anyone has an idea on this?

rmehta · April 22, 2015, 5:13am

is_custom_field is set as true when Custom Fields are appended to the doctype object (meta)

github.com

frappe/frappe/blob/c153b810e009d23a63f84c2b691a3a9b99c74113/frappe/model/meta.py#L133


      
          
          
		self.add_custom_fields()
          		self.apply_property_setters()
          		self.sort_fields()
          		self.get_valid_columns()
          
          
	def add_custom_fields(self):
          		try:
          			self.extend("fields", frappe.db.sql("""SELECT * FROM `tabCustom Field`
          				WHERE dt = %s AND docstatus < 2""", (self.name,), as_dict=1,
          				update={"is_custom_field": True}))
          		except Exception, e:
          			if e.args[0]==1146:
          				return
          			else:
          				raise
          
          
	def apply_property_setters(self):
          		for ps in frappe.db.sql("""select * from `tabProperty Setter` where
          			doc_type=%s""", (self.name,), as_dict=1):
          			if ps.doctype_or_field=='DocType':

bohlian · April 23, 2015, 6:56am

I dumped the row array to see what contents are inside and it seems the is_custom_field attribute is not present.

The following describes the dump:

{“parent”:“Customize
Form”,“allow_on_submit”:0,“precision”:“”,“in_list_view”:0,“reqd”:0,"
unique":0,“in_filter”:0,“print_hide”:0,“name”:“Customer-flat_rate_id_no”
,“idx”:22,“ignore_user_permissions”:0,“doctype”:“Customize Form
Field”,“label”:“Flat Rate ID Number”,“parenttype”:“Customize
Form”,“fieldname”:“flat_rate_id_no”,“fieldtype”:“Data”,“hidden”:0,"
permlevel":0,“report_hide”:0,“parentfield”:“fields”}

Any idea why it has such behaviour?

rmehta · April 24, 2015, 6:11am

@bohlian Fixed.

Update and check.

bohlian · April 24, 2015, 9:15am

Yes it works now. Thanks.