[v7] Deadlock in Item Attribute Table

adityaduggal · July 14, 2016, 9:38am

Hi,

Just was trying to add a new value in an existing attribute in v7 develop branch and found out the system just hangs and sometimes I get the error Another Transaction is blocking this and try after sometime

I have tried to do this after stopping and starting the bench but to no avail. I think the way the code is running to check the existing item codes for the attributes is creating a deadlock into the system, I think the problem is with:

github.com

frappe/erpnext/blob/develop/erpnext/stock/doctype/item_attribute/item_attribute.py#L25-L29


      
          	def validate(self):
          		frappe.flags.attribute_values = None
          		self.validate_numeric()
          		self.validate_duplication()

Which used to be like this below:

github.com

frappe/erpnext/blob/master/erpnext/stock/doctype/item_attribute/item_attribute.py#L43-L57


      
          				frappe.throw(_("Please specify from/to range"))
          
          
			elif self.from_range >= self.to_range:
          				frappe.throw(_("From Range has to be less than To Range"))
          
          
			if not self.increment:
          				frappe.throw(_("Increment cannot be 0"), ItemAttributeIncrementError)
          		else:
          			self.from_range = self.to_range = self.increment = 0
          
          
	def validate_duplication(self):
          		values, abbrs = [], []
          		for d in self.item_attribute_values:
          			d.abbr = d.abbr.upper()
          			if d.attribute_value in values:

@rmehta: Could you please shed some light on this as this commit was made by you:

https://github.com/frappe/erpnext/commit/aed79e993f51a7b2d4379359e516705115a55fd0

Created github Issue [v7] Deadlock in Item Variant Table · Issue #5756 · frappe/erpnext · GitHub