Validate_distance_from_shift_location error in hrms

Alexis_Dali · November 23, 2024, 3:30pm

Hello for all…
Anyone know what does this error mean

AttributeError: ‘EmployeeCheckin’ object has no attribute ‘validate_distance_from_shift_location’
Possible source of error: hrms (app)

App Versions

{
	"business_theme_v14": "0.0.1",
	"erpnext": "15.41.1",
	"erpnext_arabic_layout": "0.0.1",
	"frappe": "15.47.1",
	"hrms": "15.33.2",
	"insights": "3.0.0",
	"print_designer": "1.0.0-dev",
	"raven": "2.0.0"
}

Route

Form/Employee Checkin/new-employee-checkin-drvusebwen

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 114, in application
    response = frappe.api.handle(request)
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1781, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/frappe/frappe/desk/form/save.py", line 39, in savedocs
    doc.save()
  File "apps/frappe/frappe/model/document.py", line 337, in save
    return self._save(*args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 359, in _save
    return self.insert()
  File "apps/frappe/frappe/model/document.py", line 291, in insert
    self.run_before_save_methods()
  File "apps/frappe/frappe/model/document.py", line 1091, in run_before_save_methods
    self.run_method("validate")
  File "apps/frappe/frappe/model/document.py", line 962, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1322, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1304, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 959, in fn
    return method_object(*args, **kwargs)
  File "apps/hrms/hrms/hr/doctype/employee_checkin/employee_checkin.py", line 28, in validate
    self.validate_distance_from_shift_location()
AttributeError: 'EmployeeCheckin' object has no attribute 'validate_distance_from_shift_location'

Response Data

{
	"exception": "AttributeError: 'EmployeeCheckin' object has no attribute 'validate_distance_from_shift_location'",
	"exc_type": "AttributeError",
	"_exc_source": "hrms (app)"
}

ejaaz · November 24, 2024, 4:43am

Check in your code if this method is available.

github.com

frappe/hrms/blob/7dd0009c97a1fb60f3f8898988adfca16d5151ea/hrms/hr/doctype/employee_checkin/employee_checkin.py#L78


      
          					shift_actual_timings.shift_type.name
          				)
          			)
          		if not self.attendance:
          			self.shift = shift_actual_timings.shift_type.name
          			self.shift_actual_start = shift_actual_timings.actual_start
          			self.shift_actual_end = shift_actual_timings.actual_end
          			self.shift_start = shift_actual_timings.start_datetime
          			self.shift_end = shift_actual_timings.end_datetime
          
          	def validate_distance_from_shift_location(self):
          		if not frappe.db.get_single_value("HR Settings", "allow_geolocation_tracking"):
          			return
          
          		if not (self.latitude or self.longitude):
          			frappe.throw(_("Latitude and longitude values are required for checking in."))
          
          		assignment_locations = frappe.get_all(
          			"Shift Assignment",
          			filters={
          				"employee": self.employee,

Alexis_Dali · November 24, 2024, 5:30am

@ejaaz
Yes it is threre…

ejaaz · November 24, 2024, 5:40am

Okay, then try updating your app.

Alexis_Dali · November 24, 2024, 5:46am

@ejaaz in employee check-in section I coudn’t get the location do you have the same thing…?
I remember that I get a map here when I open it.

map like that

ejaaz · November 24, 2024, 5:51am

Have you enabled geolocation tracking in HR settings?

Alexis_Dali · November 24, 2024, 5:55am

@ejaaz
ok Now I have the map but still the same error ‘validate_distance_from_shift_location’

ejaaz · November 24, 2024, 5:58am

Have you tried updating your app?

Alexis_Dali · November 24, 2024, 6:14am

@ejaaz
Kind regards Mr.ejaaz.