[Version-12]: Loan Status not changing to Repaid/Closed when last installment is deducted

VamYip · November 1, 2020, 12:46pm

There’s a bug in version due to which Loan status is not changed to Repaid/Closed when last installment is deducted from Salary.

Adding doc.reload() after below line fixes it in my development environment. Can someone check this and raise a PR if already working on loans?

github.com

frappe/erpnext/blob/version-12/erpnext/hr/doctype/salary_slip/salary_slip.py#L917


      
          		else:
          			msgprint(_("{0}: Employee email not found, hence email not sent").format(self.employee_name))
          
          
	def update_status(self, salary_slip=None):
          		for data in self.timesheets:
          			if data.time_sheet:
          				timesheet = frappe.get_doc('Timesheet', data.time_sheet)
          				timesheet.salary_slip = salary_slip
          				timesheet.flags.ignore_validate_update_after_submit = True
          				timesheet.set_status()
          				timesheet.save()
          
          
	def update_loans(self):
          		for loan in self.get_loan_details():
          			doc = frappe.get_doc("Loan", loan.name)
          
          
			#setting repayment schedule and updating total amount to pay
          			repayment_status = 1 if doc.docstatus == 1 else 0
          			frappe.db.set_value("Repayment Schedule", loan.repayment_name, "paid", repayment_status)
          			doc.reload()
          			doc.update_total_amount_paid()

Thanks!