What is the difference between employee attribute and name attribute in employee doctype

manal_erpnext · November 13, 2024, 1:18pm

what is the difference between employee attribute and name attribute in employee doctype

NCP · November 14, 2024, 4:58am

First you have to understand the logic on code side.

frappe/erpnext/blob/develop/erpnext/setup/doctype/employee/employee.py#L29-L31


      
          	def autoname(self):
          		set_name_by_naming_series(self)
          		self.employee = self.name

github.com

frappe/erpnext/blob/develop/erpnext/setup/doctype/employee/employee.py#L59-L62


      
          	def set_employee_name(self):
          		self.employee_name = " ".join(
          			filter(lambda x: x, [self.first_name, self.middle_name, self.last_name])
          		)

manal_erpnext · November 14, 2024, 7:42am

i ask about employee and name
not employee_name
i hope you understand me question

NCP · November 14, 2024, 8:24am

again check it, i already posted.

manal_erpnext · November 14, 2024, 8:51am

as i see they are the same so why we duplicate the data in database?!

NCP · November 14, 2024, 8:52am

You have to debug the code and check the functionality.

manal_erpnext · November 14, 2024, 8:54am

I didn’t understand could you explain what you meant this is just a line
self.employee = self.name

manal_erpnext · November 14, 2024, 8:55am

assign the value of name attribute to employee attribute

NCP · November 14, 2024, 8:55am

name set in the employee field but also you have to check set_name_by_naming_series(self)

manal_erpnext · November 14, 2024, 8:58am

github.com

frappe/frappe/blob/057139ea2eb7333575b5bea7a1c8e8977780f757/frappe/model/naming.py#L253


      
          		filters={"document_type": doc.doctype, "disabled": 0},
          		order_by="priority desc",
          	)
          
          	for d in document_naming_rules:
          		frappe.get_cached_doc("Document Naming Rule", d.name).apply(doc)
          		if doc.name:
          			break
          
          
          def set_name_by_naming_series(doc):
          	"""Sets name by the `naming_series` property"""
          	if not doc.naming_series:
          		doc.naming_series = get_default_naming_series(doc.doctype)
          
          	if not doc.naming_series:
          		frappe.throw(frappe._("Naming Series mandatory"))
          
          	doc.name = make_autoname(doc.naming_series + ".#####", "", doc)

i saw the code
“”“Sets name by the naming_series property”“”
why the duplicate happen or what is the benefit of both of fields?

NCP · November 14, 2024, 8:59am

As already said, without debugging, it becomes difficult to understand this flow.

manal_erpnext · November 14, 2024, 9:33am

i did not get the idea but Question
when i use crud event for validate method
the flow start with autoname method in employee master

github.com

frappe/hrms/blob/3408536b7e3c78646a2f9cfc4e65cfd7daa03242/hrms/overrides/employee_master.py#L13


      
          
          import frappe
          from frappe import _
          from frappe.model.naming import set_name_by_naming_series
          from frappe.utils import add_years, cint, get_link_to_form, getdate
          
          from erpnext.setup.doctype.employee.employee import Employee
          
          
          class EmployeeMaster(Employee):
          	def autoname(self):
          		naming_method = frappe.db.get_value("HR Settings", None, "emp_created_by")
          		if not naming_method:
          			frappe.throw(_("Please setup Employee Naming System in Human Resource > HR Settings"))
          		else:
          			if naming_method == "Naming Series":
          				set_name_by_naming_series(self)
          			elif naming_method == "Employee Number":
          				self.name = self.employee_number
          			elif naming_method == "Full Name":
          				self.set_employee_name()

but when i use the override validate method

the flow start with autoname method in employee doctype

github.com

frappe/erpnext/blob/7be10a744da8799121364090945273e81c10d9e6/erpnext/setup/doctype/employee/employee.py#L29


      
          	pass
          
          
          class InactiveEmployeeStatusError(frappe.ValidationError):
          	pass
          
          
          class Employee(NestedSet):
          	nsm_parent_field = "reports_to"
          
          	def autoname(self):
          		set_name_by_naming_series(self)
          		self.employee = self.name
          
          	def validate(self):
          		from erpnext.controllers.status_updater import validate_status
          
          		validate_status(self.status, ["Active", "Inactive", "Suspended", "Left"])
          
          		self.employee = self.name
          		self.set_employee_name()

why?