Where can I change the whole layout of erpnext from LTR to RTL?

Rebaz_Balisani · September 20, 2024, 8:59pm

I have added my local language which is similar to Arabic and it works very fine only the layout sticks to the LTR like english, I want to switch the layout to be like Arabic as well RTL. where can I trigger this?
Thank you very much in advance

this is a screenshot of my local language which is rtl and we use majority of Arabic letters, it supposed to be like Arabic i mean the whole layout eg. sidebar should be from the right etc… now its like English

sorry to tag you bro @NCP your kind support is highly apprciated

ALAADIAA · September 21, 2024, 7:21pm

I am not sure if this will help you but this was our experience in creating content for Arabic -RTL language- but I share if that help

Rebaz_Balisani · September 22, 2024, 11:19am

@avc can you guide on thia please

Rebaz_Balisani · September 22, 2024, 2:08pm

thank you very @ALAADIAA , thats great. i will consider it for frappe apps that i will be working on. I was wondering to find the function which Triggers the switch between LTR to RTL and vice versa in ERPNext. i am eagerly waiting from the community and/or Frappe team to guide on this

avc · September 22, 2024, 2:16pm

Sorry, @Rebaz_Balisani I can’t help here. Never managed RTL …

Rebaz_Balisani · September 22, 2024, 2:51pm

Thank you @avc , no problem

ALAADIAA · September 22, 2024, 3:00pm

I guess that but I think it maybe help if you investigate more

Rebaz_Balisani · September 22, 2024, 3:50pm

Thank you brother @ALAADIAA , the problem is when adding a new language, by default it gets (dir=ltr) and there is no option anywhere in the frappe/erpnext system to define that the newly added language is RTL not LTR.

avc · September 22, 2024, 8:04pm

Hi @Rebaz_Balisani:

I’ve diggin’ a little about it …
Currently, this languages are defined as RTL

["ar", "he", "fa", "ps"]

I tried and it works well

Now … I don’t know how to get back!

There is the key

github.com

frappe/frappe/blob/d3248612cbf143c3d9a6edeeba63b3724e9bf019/frappe/public/js/frappe/utils/utils.js#L1052


      
          		} else {
          			let input = $("<textarea>");
          			$("body").append(input);
          			input.val(string).select();
          
          			document.execCommand("copy");
          			show_success_alert();
          			input.remove();
          		}
          	},
          	is_rtl(lang = null) {
          		return ["ar", "he", "fa", "ps"].includes(lang || frappe.boot.lang);
          	},
          	bind_actions_with_object($el, object) {
          		// remove previously bound event
          		$($el).off("click.class_actions");
          		// attach new event
          		$($el).on("click.class_actions", "[data-action]", (e) => {
          			let $target = $(e.currentTarget);
          			let action = $target.data("action");
          			let method = object[action];

Hope this helps.

Gharieb · September 22, 2024, 8:40pm

you can change the layout of the system from language in system settings
but i do use RTL and i prefer to keep the system in English and change the language of the users to achive that

Rebaz_Balisani · September 22, 2024, 9:45pm

I appreciate your time and efforts brother, i came across it and started searching for this file but eventually i found out that its not in any of the V14 or v15 its a separate branch, i was wondering something within latest versions such as v15 or develop branch

Rebaz_Balisani · September 22, 2024, 9:46pm

Brother Gharieb I appreciate if you could show me a screenshot of this trigger/switch because I indeed need the rtl

avc · September 22, 2024, 9:48pm

Hi @Rebaz_Balisani:

There is related code on .py files too … version-15 branch.

github.com

frappe/frappe/blob/d3248612cbf143c3d9a6edeeba63b3724e9bf019/frappe/utils/jinja_globals.py#L160


      
          
          	if ".bundle." in path and not path.startswith("/assets"):
          		bundled_assets = get_assets_json()
          		if path.endswith(".css") and is_rtl(rtl):
          			path = f"rtl_{path}"
          		path = bundled_assets.get(path) or path
          
          	return abs_url(path)
          
          
          def is_rtl(rtl=None):
          	from frappe import local
          
          	if rtl is None:
          		return local.lang in ["ar", "he", "fa", "ps"]
          	return rtl

Gharieb · September 22, 2024, 10:01pm

I actually tried on my version before i reply your message and the english just disappeared and the whole system layout convert it to RTL which i don’t know yet how i’ll convert it back. in the framework the layout should be changed based on the user language, but if you change the language of the system that will convert the layout of the desk view based on the language. in the awsome bar just write system settings or if you changed the Lang it shuold have the same meaning

Rebaz_Balisani · September 22, 2024, 10:05pm

brother you just changed the language. Not changing the language, chaning the ltr to the rtl, because my language does not exisit in the ERPNext/Frappe and i have added it myself. by default adding any new language to the system will be LTR so my issue is my newly added language is RTL. I hate to touch dozens of html, css, py, js files to achieve this which finally i am sure will brings up dozens of issues within website pages, doctypes, layouts, prints etc…

Gharieb · September 22, 2024, 10:10pm

did you try to check your language in language list there are 80 langs in ver 15 you can enable any language from there

avc · September 22, 2024, 10:10pm

Hi @Rebaz_Balisani:

Best solution here could be raising an issue, asking for RTL setting for your language. Other users can benefit.

Meanwhile … maybe you can override this .py and .js methods

frappe.utils.is_rtl (js)
frappe.utils.jinja_globals.is_rtl (python)

Gharieb · September 22, 2024, 10:14pm

which language you need

if you create a custom lang chose in based on field a lang RTL

Rebaz_Balisani · September 22, 2024, 10:27pm

Thanks for your time and support, i have already chosen BASED ON: ARABIC but it did not help

Rebaz_Balisani · September 22, 2024, 10:33pm

Thank you very much for your support and guidance, today I subimtted a feature request for that i dont know if they will add it soon or will be for late future