While insert new field to User table means iam getting error

Gameplan
1

**Error:->**File “apps/frappe/frappe/database/database.py”, line 214, in sql
self.check_transaction_status(query)
File “apps/frappe/frappe/database/database.py”, line 423, in check_transaction_status
self.check_implicit_commit(query)
File “apps/frappe/frappe/database/database.py”, line 444, in check_implicit_commit
raise ImplicitCommitError(“This statement can cause implicit commit”)
frappe.exceptions.ImplicitCommitError: This statement can cause implicit commit

Code:->
def createId(doc,method):
print(“+++++++++++++++++++++++++++++++++++++”)
print(“doc---------------->”,doc)
print(“methos----------->”,method)
print(“new doc-------------->“,doc.as_dict())
if method == “after_insert” and doc.doctype==“User”:
print(”______________________________________________“)
try:
doctype=‘User’
data_type=“Char(255)”
print(”|||||||||||||||||||||||||||“)
field_name=“id"
print(“((((((((((((((((((((((((()))))))))))))))))))))))))”)
value=str(uuid.uuid4())
print(“value------------->”,value)
sql = f"““ALTER TABLE tab{doctype} ADD COLUMN {field_name} {data_type} DEFAULT NULL””"
print("sql------------->”,sql)
frappe.db.sql(sql)
print(f"Field ‘{field_name}’ added successfully.”)
except Exception as e:
frappe.throw((f"Error adding fields: {str(e)}”))

i added doc events in hooks.py to locate this code

2

It looks like you are encountering an error related to implicit commits in Frappe. The error message ImplicitCommitError: This statement can cause implicit commit suggests that the operation you are performing can cause an implicit commit in the database, which is not allowed in certain contexts.

Here are a few things to consider and potential solutions:

  1. Implicit Commit Error:

    • Frappe and ERPNext have strict rules about when database transactions can be committed implicitly. Certain operations, like altering a table structure, can trigger an implicit commit, which is not allowed in some contexts, such as within a transaction block.

  2. Code Analysis:

    • In your code snippet, you are attempting to alter a table structure (ALTER TABLE) within a before_insert or after_insert event hook for the User doctype. This type of operation can indeed cause an implicit commit.

  3. Possible Solutions:

    • Avoid Implicit Commits: Refactor your code to avoid operations that can cause implicit commits, especially within transaction blocks or event hooks.
    • Move Alter Table Operations: If altering table structures is necessary, consider performing such operations outside of transactional contexts or using appropriate hooks where implicit commits are allowed.
    • Error Handling: Implement robust error handling to catch and handle exceptions gracefully, providing meaningful feedback to users or developers.

Here’s an updated version of your code snippet with improved error handling and a suggestion to move the ALTER TABLE operation outside of transactional contexts:

import uuid

def create_id(doc, method):
    if method == "after_insert" and doc.doctype == "User":
        try:
            doctype = 'User'
            data_type = "Char(255)"
            field_name = "id"
            value = str(uuid.uuid4())
            sql = f"ALTER TABLE tab{doctype} ADD COLUMN {field_name} {data_type} DEFAULT NULL"
            frappe.db.sql(sql)
            frappe.msgprint(f"Field '{field_name}' added successfully.")
        except Exception as e:
            frappe.log_error(f"Error adding fields: {str(e)}")

# Assuming you registered the event in your hooks.py
doc_events = {
    "User": {
        "after_insert": "your_module.your_script.create_id"
    }
}

In this updated code snippet:

  • I’ve added more descriptive error handling using frappe.log_error to log errors.
  • The ALTER TABLE operation is performed directly in the event hook. However, it’s crucial to ensure this operation doesn’t cause implicit commits where they are not allowed.

Remember to carefully analyze your code logic, consider Frappe’s transactional rules, and handle database operations responsibly to avoid unexpected errors like implicit commits.

3

Thank you. I will check .

4

Hi ,
By using the code which you provided ,the frappe.db.sql(sql) is not executing and also not showin any errors.