Why do we require a Process Payment Reconciliation during PCV?

ERPNext Accounting
,
1

When you try to close a period via Period Closing Voucher in erpnext v16.25.0, the PCV requires Process Period Closing Voucher with an PCV- code. Looks like the start_pcv_processing function in process_period_closing_voucher.py line 52 has a typoo

@frappe.whitelist()
def start_pcv_processing(docname: str):
if frappe.db.get_value(“Process Period Closing Voucher”, docname, “status”) in [“Queued”, “Running”]:

THIS IS THE WRONG DOCTYPE

frappe.has_permission(“Process Payment Reconciliation”, “write”, doc=docname, throw=True)
frappe.db.set_value(“Process Period Closing Voucher”, docname, “status”, “Running”)

should be

@frappe.whitelist()
def start_pcv_processing(docname: str):
if frappe.db.get_value(“Process Period Closing Voucher”, docname, “status”) in [“Queued”, “Running”]:

CORRECTED DOCTYPE

frappe.has_permission(“Process Period Closing Voucher”, “write”, doc=docname, throw=True)
frappe.db.set_value(“Process Period Closing Voucher”, docname, “status”, “Running”)

2

Fixed