Thanks @iMoshi for your suggestion. I confirmed bench update executes correctly when --no-backup is specified.
For the benefit of others, this this does not solve the underlying problem, and “bench update” still fails afterwards, which I assume means something is broken and will be fixed (“bench update --help” even says “–no-backup” is not recommended on production systems!) I will snapshot the server vm before updating and create backups manually as a workaround until it’s fixed.
@Dale_Scott@iMoshi Please do git pull in your .bench and test again if its working and please test if putting parameter --no-backup it will not do a backup.
The bench code git repo is found in .bench that sits next to the frappe-bench directory, for eg typically /home/frappe/frappe-bench & /home/frappe/.bench
In my local case, this lists the last merge commits included in my most recent bench update a few weeks ago, destined for my local bench code repo:
You could also try bench update from outside a bench directory. If you’re not sure if you are in a bench directory, you could try bench find . just to be sure. Or even just execute cd && bench update. If you want to manually just pull the bench changes but not update it’s requirements, you could also try cd $(bench src) && git pull
Running bench update outside of a bench directory will update the bench tool.
@gavindsouza this is what I was trying to tell you. Me and @Dale_Scott have the same behavior the logic is switch when you put --no-backup it will backup if you do not put the option it will not backup. My first PR solve this problem.