Incorrect Valuation Rate in Stock Ledger and Repost Item Valuation not working for back dated cancelation [Release v13.0.0]

ushashmi · April 4, 2021, 3:58pm

When any back dated stock transaction is cancelled then repost item valuation get stuck in Queued and stock ledger is not getting updated. I have tested this on latest [Release v13.0.0].

Later if we post any new transaction for the same item in current date then the item valuation gets updated only for the new transaction and stock balance value get corrected however, all the previous transactions which were recorded prior to current transaction still show wrong calculation in stock ledger.

ushashmi · April 6, 2021, 2:46am

Moreover the valuation rate is not calculating correctly. Please see in below picture

As visible in above ledger the incoming rate is always 2800 however after some back dated cancelations the repost functionality has calculated wrong valuation rate.

ushashmi · April 11, 2021, 12:35pm

Wondering if anyone got the same problem

Looking for possible solutions

zerodiscount · April 11, 2021, 1:03pm

It seems also the balance value suddenly jumps after purchase of 5 kg.

We faced similar issue - but in our case - the item quantities went completely off after the initial attempts. We are on FIFO. We followed these steps to resolve - unsure if/why needed - and not clear why they worked.

Check if there are subsequent stock reconciliations - cancel them. Cancel/delete any pending repost item valuations and attempt them again. Start with the earliest first where you notice an error and then move forward in time with each step. Depending on size of ledger repost item valuation can take time.

Sorry cannot help you more - but would be interesting for the community to learn how you resolve this issue…

ushashmi · April 11, 2021, 2:46pm

We managed to correct the stock ledger and valuation rate once- not sure how but after so many trials and errors. However later on there was one back dated purchase receipt posted and again the stock ledger went crazy!!!

Very confused with this calculation!!!

Tufan_Kaynak2 · May 29, 2021, 10:10am

This reposting idea is knid of bullshit right now. Locks many things up and why it is needed at that stage of maturity is unknown. Messed up all the accounting.

Azhar_Islam · June 15, 2021, 8:26pm

@rmehta This seems like a major issue. Our ERP is showing incorrect stock and valuation. And I think the reason is stock ledger entry getting messed up. Is there a way to manually trigger recalculation/reposting of everything?

Tufan_Kaynak2 · June 26, 2021, 9:21am

Dears, @rmehta,
this kind of valuation was not a problem before. Even before diving into the coding itself, we’ve been using perpetual inventory from the start. Now, we receive correction entry requests during stock transaction which were not an issue before. The rate is up to 10% of the inventory value.
Someone should delve into this problem to check what is going on and if it makes any business sense.
Financials is the key to corporate accounts and just this question will decrease the value of the product.
I just don’t understand why a system is posting valuation difference entries now that we are using Erpnext for over 5 years.

youssef · June 26, 2021, 8:16pm

We are using this function to correct the stock ledger and valuation rate, originally it was a patch in V13

github.com

aakvatech/CSF_TZ/blob/master/csf_tz/csftz_hooks/item_reposting.py

import frappe
from frappe import _
from frappe.utils import getdate, get_time, today
from erpnext.stock.stock_ledger import update_entries_after
from erpnext.accounts.utils import update_gl_entries_after
from frappe.utils.background_jobs import enqueue

def execute():
	for doctype in ('repost_item_valuation', 'stock_entry_detail', 'purchase_receipt_item',
			'purchase_invoice_item', 'delivery_note_item', 'sales_invoice_item', 'packed_item'):
		frappe.reload_doc('stock', 'doctype', doctype)
	frappe.reload_doc('buying', 'doctype', 'purchase_receipt_item_supplied')

	sle_gle_reposting_start_date = frappe.get_value("CSF TZ Settings", "CSF TZ Settings", "sle_gle_reposting_start_date")
	if not sle_gle_reposting_start_date:
		frappe.throw(_("SLE GLE Reposting Start Date not set in {0}").format(frappe.utils.get_url_to_form("CSF TZ Settings", "CSF TZ Settings")))
	reposting_project_deployed_on = sle_gle_reposting_start_date + " 00:00:00"
	posting_date = sle_gle_reposting_start_date
	posting_time = '00:00:00'

This file has been truncated. show original

We have a setting in the custom app to enqueue this function and also we setting their reposting start date

github.com

aakvatech/CSF_TZ/blob/2d433823df339b308a4683b49b201523204b5298/csf_tz/csf_tz/doctype/csf_tz_settings/csf_tz_settings.js

// Copyright (c) 2020, Aakvatech and contributors
// For license information, please see license.txt

frappe.ui.form.on('CSF TZ Settings', {
	start_sle_gle_reporting: function (frm) {
        frappe.call({
            method: 'csf_tz.csftz_hooks.item_reposting.enqueue_reposting_sle_gle',
            callback: function (data) {
                console.log(data);
            }
        })
    },
});

The process may take an hour or a day depends on the existing data and the server’s power

I hope it will help

ushashmi · June 27, 2021, 11:13am

Thanks a lot @youssef… i will test this and update the results.

Just one clarification, if the repost entries are already stuck in queue, Will this code restart them over again or they will be stuck there and new repost will run?

youssef · June 27, 2021, 3:31pm

you have to wait for it to be finished before you start a new one.

Tufan_Kaynak2 · June 29, 2021, 1:07pm

How was it working before? Why are GL Entries updated? How can we keep a consistent ledger if it keeps being updated in every transaction? Say, we submitted the GL on 30-06-2021 and did a stock entry in 01-07-2021, will that change the GL entry in 30-06-2021? Just does not hold up! Just because it can be codded does not mean it is correct business wise!

aakvatech · September 9, 2021, 3:54am

If you do Stock Entry on 1st July 2021 but posting date is 30th June 2021, it will repost GL entries then. Otherwise, it will continue normally.