Mobile View missing Standard Filters

Jonathan_Lee · October 30, 2018, 1:50pm

Hi everyone,

As I found out from the following github entry. The standard filter has been deliberately limited to 3 fields only. While i understood the intention is to achieve better User Experience for mobile user, I don’t quite agree with the approach to sacrifice functionality in order to achieve it.

https://github.com/frappe/erpnext/issues/9741

Moreover, this change has impacted my user and they are claiming the mobile version is totally unusable due to this change. Can I suggest we unhide these fields or at least make it expandable/collapsible on the mobile view?

In the meantime, we’d like to undo this change ourselves, can anyone tell us where do we need to edit to show all standard filters on the mobile view?

Thank you.

magic-overflow · October 30, 2018, 4:39pm

Check this, it may help

github.com

frappe/frappe/blob/ee3ae7abea4e4bbe8bc11a29e9e385f2cb1ac0f4/frappe/public/js/frappe/ui/base_list.js#L233


      
          
          
					let f = me.page.add_field({
          						fieldtype: fieldtype,
          						label: __(df.label),
          						options: options,
          						fieldname: df.fieldname,
          						condition: condition,
          						onchange: () => {me.refresh(true);}
          					});
          					filter_count ++;
          					if (filter_count > 3) {
          						$(f.wrapper).addClass('hidden-sm').addClass('hidden-xs');
          					}
          					if (filter_count > 5) {
          						return false;
          					}
          				}
          			});
          		}
          
          
		this.standard_filters_added = true;

Jonathan_Lee · October 30, 2018, 5:40pm

Thank you!
This did the trick!
//if (filter_count > 3) {
// $(f.wrapper).addClass(‘hidden-sm’).addClass(‘hidden-xs’);
//}

magic-overflow · October 31, 2018, 1:40am

Glad it helped. You should mark the post as solution to close this thread.

Jonathan_Lee · October 31, 2018, 5:39am

Yup sure, please proceed to close this thread