Serious performance bottleneck for linked fields in Frappe

manasan · January 29, 2021, 3:14pm

On any frappe doctype, if you enter value into any linked field, two exactly similar ajax calls to frappe.desk.form.utils.validate_link is performed. I tested this on version-13-beta, I am not sure whether this issue prevails in version-12. I tried to find the root cause and it seems like multiple same calls are performed in #L184 and #L187 of base_control.js.

github.com

frappe/frappe/blob/develop/frappe/public/js/frappe/form/controls/base_control.js#L184


      
          			.on("click", () => {
          				if (!this.doc.__islocal) {
          					new frappe.views.TranslationManager({
          						df: this.df,
          						source_text: this.value,
          						target_language: this.doc.language,
          						doc: this.doc,
          					});
          				}
          			});
          	}
          	get_doc() {
          		return (
          			(this.doctype &&
          				this.docname &&
          				locals[this.doctype] &&
          				locals[this.doctype][this.docname]) ||
          			{}
          		);
          	}
          	get_model_value() {

I am not sure whether I am getting something wrong here but this seems like an obvious performance issue. Especially in DocTypes like Quotation and Sales Invoice that performs a lot of link field validations.

Same Validation Calls being performed TWICE

manasan · March 5, 2021, 12:03pm

I am observing this in V12 too, can anyone else confirm this issue?