Syntax error in apps/erpnext/erpnext/accounts/doctype/share_transfer/share_transfer.py

I noticed this message in the terminal window executing bench update (after importing a database into a new Ubuntu 20.04 LTS server with baked-in Python3, in case it is relevant).

Compiling Python Files...
../apps/erpnext/erpnext/accounts/doctype/share_transfer/share_transfer.py:172: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  shareholders = [shareholder for shareholder in shareholders if self.get(shareholder) is not '']

Can anyone shine any light on the potential effect? I created a issue report on Github but no comments yet. Should I just submit a pull request with the suggested syntax change from the compiler?

https://github.com/frappe/erpnext/issues/22271

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.